Re: [Mesa-dev] [PATCH v2] glsl: Fix aggregates with dynamic initializers.

2014-07-10 Thread Cody Northrop
No, that's the same experiment I would have run. I was hoping the original authors could chime in, but it sounds like you have more insight via AoA work. I'll resubmit with your change, thanks! -C On Wed, Jul 9, 2014 at 5:36 PM, Timothy Arceri wrote: > On Wed, 2014-07-02 at 22:16 +1000, Tim

Re: [Mesa-dev] [PATCH v2] glsl: Fix aggregates with dynamic initializers.

2014-07-09 Thread Timothy Arceri
On Wed, 2014-07-02 at 22:16 +1000, Timothy Arceri wrote: > On Tue, 2014-07-01 at 14:45 -0700, Kenneth Graunke wrote: > > From: Cody Northrop > > > > Vectors are falling in to the ir_dereference_array() path. > > > > Without this change, the following glsl aborts the debug driver, > > or gets the

Re: [Mesa-dev] [PATCH v2] glsl: Fix aggregates with dynamic initializers.

2014-07-02 Thread Timothy Arceri
On Tue, 2014-07-01 at 14:45 -0700, Kenneth Graunke wrote: > From: Cody Northrop > > Vectors are falling in to the ir_dereference_array() path. > > Without this change, the following glsl aborts the debug driver, > or gets the wrong answer in release: > > mat2x2 a = mat2( vec2( 1.0, vertex.x ),

[Mesa-dev] [PATCH v2] glsl: Fix aggregates with dynamic initializers.

2014-07-01 Thread Kenneth Graunke
From: Cody Northrop Vectors are falling in to the ir_dereference_array() path. Without this change, the following glsl aborts the debug driver, or gets the wrong answer in release: mat2x2 a = mat2( vec2( 1.0, vertex.x ), vec2( 0.0, 1.0 ) ); Also submitting piglit tests, will reference in bug.