Hi Iago,
given that the idea here was to unify vec4 and fs you might want to
adopt the names/function types accordingly.
In brw_ir_fs.h there is byte_offset that returns a fs_reg while you have
void add_byte_offset.
--Michael
Am 23.08.2016 um 10:24 schrieb Iago Toral Quiroga:
> This will make i
On Tue, 2016-08-23 at 11:21 +0200, Michael Schellenberger Costa wrote:
> Hi Iago,
>
> given that the idea here was to unify vec4 and fs you might want to
> adopt the names/function types accordingly.
>
> In brw_ir_fs.h there is byte_offset that returns a fs_reg while you
> have
> void add_byte_of
This will make it more consistent with the FS implementation of the same
helper and will provide more flexibility that will come in handy, for
example, when we add a SIMD lowering pass in the vec4 backend.
v2:
- Move the switch statement to add_byte_offset (Iago)
- Remove the assert on the regis
