Re: [Mesa-dev] [PATCH v2] math: Import isinf and others to global namespace

I just noticed you initial patch said "(and glibc >= 2.23)". I don't have it. So maybe that's all we need is check __GLIBC__ / _GLIBC_MINOR__ and only do it then. Jose On 13/04/16 15:21, Jose Fonseca wrote: > This was with GLIBC 2.21 in ubuntu 15.10: > > $ ldd --version > ldd (Ubuntu GLIBC

Re: [Mesa-dev] [PATCH v2] math: Import isinf and others to global namespace

This was with GLIBC 2.21 in ubuntu 15.10: $ ldd --version ldd (Ubuntu GLIBC 2.21-0ubuntu4.1) 2.21 And it was with GCC 5.0. I also tried GCC 4.9 but no difference. And the funny thing is that I can't repro the nouveau build failure neither. _Something_ causes these functions to be available on

Re: [Mesa-dev] [PATCH v2] math: Import isinf and others to global namespace

:-( I'll have another look this evening. Which version of glibc did it failed with? (I saw your reply to the other patch, I'll dig deeper this evening.) Thanks! Pierre > On 13 Apr 2016, at 08:22, Jose Fonseca wrote: > >> On 01/04/16 13:18, Pierre Moreau wrote: >>> On

Re: [Mesa-dev] [PATCH v2] math: Import isinf and others to global namespace

On 01/04/16 13:18, Pierre Moreau wrote: On 01:11 PM - Apr 01 2016, Jose Fonseca wrote: On 31/03/16 23:08, Pierre Moreau wrote: Starting from C++11, several math functions, like isinf, moved into the std namespace. Since cmath undefines those functions before redefining them inside the

Re: [Mesa-dev] [PATCH v2] math: Import isinf and others to global namespace

On 01:11 PM - Apr 01 2016, Jose Fonseca wrote: > On 31/03/16 23:08, Pierre Moreau wrote: > >Starting from C++11, several math functions, like isinf, moved into the std > >namespace. Since cmath undefines those functions before redefining them > >inside > >the namespace, and glibc 2.23 defines the

Re: [Mesa-dev] [PATCH v2] math: Import isinf and others to global namespace

On 31/03/16 23:08, Pierre Moreau wrote: Starting from C++11, several math functions, like isinf, moved into the std namespace. Since cmath undefines those functions before redefining them inside the namespace, and glibc 2.23 defines the C variants as macros, the C variants in global namespace

[Mesa-dev] [PATCH v2] math: Import isinf and others to global namespace

Starting from C++11, several math functions, like isinf, moved into the std namespace. Since cmath undefines those functions before redefining them inside the namespace, and glibc 2.23 defines the C variants as macros, the C variants in global namespace are not accessible any longer. v2: Move the