Re: [Mesa-dev] [PATCH v2] nir: fix assert for wildcard pairs

2016-05-05 Thread Eduardo Lima Mitev
On 05/05/2016 04:37 AM, Thomas H.P. Andersen wrote: > > > On Wed, May 4, 2016 at 7:46 AM, Eduardo Lima Mitev > wrote: > > Good catch! > > Reviewed-by: Eduardo Lima Mitev > > > > Thanks! I do not have commit access. Can I ask you

Re: [Mesa-dev] [PATCH v2] nir: fix assert for wildcard pairs

2016-05-04 Thread Thomas H.P. Andersen
On Wed, May 4, 2016 at 7:46 AM, Eduardo Lima Mitev wrote: > Good catch! > > Reviewed-by: Eduardo Lima Mitev > Thanks! I do not have commit access. Can I ask you to push? > > On 05/04/2016 05:48 AM, Thomas Hindoe Paaboel Andersen wrote: > > The assert was null checking dest_arr_parent twice. Th

Re: [Mesa-dev] [PATCH v2] nir: fix assert for wildcard pairs

2016-05-03 Thread Eduardo Lima Mitev
Good catch! Reviewed-by: Eduardo Lima Mitev On 05/04/2016 05:48 AM, Thomas Hindoe Paaboel Andersen wrote: > The assert was null checking dest_arr_parent twice. The intention > seems to be to check both dest_ and src_. > > Added in d3636da9 > --- > v2: > Fix the assert rather than checking bot

[Mesa-dev] [PATCH v2] nir: fix assert for wildcard pairs

2016-05-03 Thread Thomas Hindoe Paaboel Andersen
The assert was null checking dest_arr_parent twice. The intention seems to be to check both dest_ and src_. Added in d3636da9 --- v2: Fix the assert rather than checking both in the if(). Hat tip to Ilia. src/compiler/nir/nir_lower_var_copies.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion