Re: [Mesa-dev] [PATCH v2 0/3][RFC]mesa/st: glsl_to_tgsi: improved temp-reg lifetime estimation

2017-06-17 Thread Emil Velikov
On 16 June 2017 at 17:16, Gert Wollny wrote: > Hello Emil, > > Am Freitag, den 16.06.2017, 15:21 +0100 schrieb Emil Velikov: >> >> Please don't use STL within core mesa code. > May I ask why? I always try to not re-implement already available > functionality and since mesa

Re: [Mesa-dev] [PATCH v2 0/3][RFC]mesa/st: glsl_to_tgsi: improved temp-reg lifetime estimation

2017-06-16 Thread Gert Wollny
Hello Emil, Am Freitag, den 16.06.2017, 15:21 +0100 schrieb Emil Velikov: > > Please don't use STL within core mesa code. May I ask why? I always try to not re-implement already available functionality and since mesa already uses C++ it seems kind of natural to use the STL because it provides

Re: [Mesa-dev] [PATCH v2 0/3][RFC]mesa/st: glsl_to_tgsi: improved temp-reg lifetime estimation

2017-06-16 Thread Emil Velikov
Hi Gert, Welcome to Mesa, and apologies for chiming in so late. Please don't use STL within core mesa code. While some places do use it, those are quite isolated and have specific role. For example: - st/clover - heavily templated, pure C++ - drivers/swr - as above - drivers/nouveau/codegen -

[Mesa-dev] [PATCH v2 0/3][RFC]mesa/st: glsl_to_tgsi: improved temp-reg lifetime estimation

2017-06-16 Thread Gert Wollny
Dear all, with the help of Nicolai's comments I rewrote the proposed patch set to improve the register renaming. The patch is related to bugs where shader compilation fails with "- translation from TGSI failed!" Among these is https://bugs.freedesktop.org/show_bug.cgi?id=65448 which I