Re: [Mesa-dev] [PATCH v2 02/14] meta: Fix transfer operations check in meta pbo path for readpixels

2015-07-20 Thread Iago Toral
On Fri, 2015-07-17 at 10:36 -0700, Anuj Phogat wrote: > Iago, Jason: Patches 2 and 5 in this series depend on patches 1 and 4 > respectively, Since you guys reviewed 2 and 5, would you also like to > review 1, 4 and/or other patches in this series? > > Thanks > -Anuj Sure, I'll have a look at the

Re: [Mesa-dev] [PATCH v2 02/14] meta: Fix transfer operations check in meta pbo path for readpixels

2015-07-17 Thread Anuj Phogat
Iago, Jason: Patches 2 and 5 in this series depend on patches 1 and 4 respectively, Since you guys reviewed 2 and 5, would you also like to review 1, 4 and/or other patches in this series? Thanks -Anuj On Sun, Jun 28, 2015 at 11:29 PM, Iago Toral wrote: > Reviewed-by: Iago Toral Quiroga > > On

Re: [Mesa-dev] [PATCH v2 02/14] meta: Fix transfer operations check in meta pbo path for readpixels

2015-06-28 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Fri, 2015-06-26 at 13:15 -0700, Anuj Phogat wrote: > Currently used ctx->_ImageTransferState check is not sufficient > because it doesn't include the read color clamping enabled with > GL_CLAMP_READ_COLOR. So, use the helper function > _mesa_get_readpixels_trans

[Mesa-dev] [PATCH v2 02/14] meta: Fix transfer operations check in meta pbo path for readpixels

2015-06-26 Thread Anuj Phogat
Currently used ctx->_ImageTransferState check is not sufficient because it doesn't include the read color clamping enabled with GL_CLAMP_READ_COLOR. So, use the helper function _mesa_get_readpixels_transfer_ops(). Also, transfer operations don't affect glGetTexImage(). So, do the check only for gl