Re: [Mesa-dev] [PATCH v2 05/11] anv: modify the internal concept of format to express multiple planes

2017-10-03 Thread Jason Ekstrand
I made some comments on v1 of this patch which appear to have gone unanswered. The two I think are important are 1) Naming. Should it be plane_format or format_plane? I think I mildly prefer the later but coulbe be confinced. 2) I don't think anv_get_isl_format needs to be renamed. It alread

[Mesa-dev] [PATCH v2 05/11] anv: modify the internal concept of format to express multiple planes

2017-10-03 Thread Lionel Landwerlin
A given Vulkan format can now be decomposed into a set of planes. We now use 'struct anv_format_plane' to represent the format of those planes. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_blorp.c | 31 +-- src/intel/vulkan/anv_formats.c | 505