Re: [Mesa-dev] [PATCH v2 09/24] anv/cmd_buffer: Generalize transition_color_buffer

2018-01-24 Thread Nanley Chery
On Wed, Jan 24, 2018 at 02:32:02PM -0800, Jason Ekstrand wrote: > On Wed, Jan 24, 2018 at 1:59 PM, Nanley Chery wrote: > > > On Mon, Jan 22, 2018 at 06:39:52PM -0800, Jason Ekstrand wrote: > > > On Mon, Jan 22, 2018 at 5:50 PM, Jason Ekstrand > > >

Re: [Mesa-dev] [PATCH v2 09/24] anv/cmd_buffer: Generalize transition_color_buffer

2018-01-24 Thread Jason Ekstrand
On Wed, Jan 24, 2018 at 1:59 PM, Nanley Chery wrote: > On Mon, Jan 22, 2018 at 06:39:52PM -0800, Jason Ekstrand wrote: > > On Mon, Jan 22, 2018 at 5:50 PM, Jason Ekstrand > > wrote: > > > > > On Mon, Jan 22, 2018 at 11:31 AM, Nanley Chery

Re: [Mesa-dev] [PATCH v2 09/24] anv/cmd_buffer: Generalize transition_color_buffer

2018-01-24 Thread Nanley Chery
On Mon, Jan 22, 2018 at 06:39:52PM -0800, Jason Ekstrand wrote: > On Mon, Jan 22, 2018 at 5:50 PM, Jason Ekstrand > wrote: > > > On Mon, Jan 22, 2018 at 11:31 AM, Nanley Chery > > wrote: > > > >> On Fri, Jan 19, 2018 at 03:47:26PM -0800, Jason

Re: [Mesa-dev] [PATCH v2 09/24] anv/cmd_buffer: Generalize transition_color_buffer

2018-01-22 Thread Jason Ekstrand
On Mon, Jan 22, 2018 at 5:50 PM, Jason Ekstrand wrote: > On Mon, Jan 22, 2018 at 11:31 AM, Nanley Chery > wrote: > >> On Fri, Jan 19, 2018 at 03:47:26PM -0800, Jason Ekstrand wrote: >> > This moves it to being based on layout_to_aux_usage instead of

Re: [Mesa-dev] [PATCH v2 09/24] anv/cmd_buffer: Generalize transition_color_buffer

2018-01-22 Thread Jason Ekstrand
On Mon, Jan 22, 2018 at 11:31 AM, Nanley Chery wrote: > On Fri, Jan 19, 2018 at 03:47:26PM -0800, Jason Ekstrand wrote: > > This moves it to being based on layout_to_aux_usage instead of being > > hard-coded based on bits of a priori knowledge of how transitions > >

Re: [Mesa-dev] [PATCH v2 09/24] anv/cmd_buffer: Generalize transition_color_buffer

2018-01-22 Thread Nanley Chery
On Fri, Jan 19, 2018 at 03:47:26PM -0800, Jason Ekstrand wrote: > This moves it to being based on layout_to_aux_usage instead of being > hard-coded based on bits of a priori knowledge of how transitions > interact with layouts. This conceptually simplifies things because > we're now using

Re: [Mesa-dev] [PATCH v2 09/24] anv/cmd_buffer: Generalize transition_color_buffer

2018-01-22 Thread Pohjolainen, Topi
On Mon, Jan 22, 2018 at 12:30:30AM -0800, Jason Ekstrand wrote: > On Mon, Jan 22, 2018 at 12:17 AM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Fri, Jan 19, 2018 at 03:47:26PM -0800, Jason Ekstrand wrote: > > > This moves it to being based on layout_to_aux_usage instead of

Re: [Mesa-dev] [PATCH v2 09/24] anv/cmd_buffer: Generalize transition_color_buffer

2018-01-22 Thread Jason Ekstrand
On Mon, Jan 22, 2018 at 12:17 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Jan 19, 2018 at 03:47:26PM -0800, Jason Ekstrand wrote: > > This moves it to being based on layout_to_aux_usage instead of being > > hard-coded based on bits of a priori knowledge of how transitions

Re: [Mesa-dev] [PATCH v2 09/24] anv/cmd_buffer: Generalize transition_color_buffer

2018-01-22 Thread Pohjolainen, Topi
On Fri, Jan 19, 2018 at 03:47:26PM -0800, Jason Ekstrand wrote: > This moves it to being based on layout_to_aux_usage instead of being > hard-coded based on bits of a priori knowledge of how transitions > interact with layouts. This conceptually simplifies things because > we're now using

[Mesa-dev] [PATCH v2 09/24] anv/cmd_buffer: Generalize transition_color_buffer

2018-01-19 Thread Jason Ekstrand
This moves it to being based on layout_to_aux_usage instead of being hard-coded based on bits of a priori knowledge of how transitions interact with layouts. This conceptually simplifies things because we're now using layout_to_aux_usage and layout_supports_fast_clear to make resolve decisions so