Re: [Mesa-dev] [PATCH v2 1/2] i965/vec4: fix swizzle and writemask when loading an uniform with constant offset

2017-05-03 Thread Samuel Iglesias Gonsálvez
On Tue, 2017-05-02 at 12:23 -0700, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > El Viernes, 28 de abril de 2017 16:08:35 Francisco Jerez escribió: > > > Samuel Iglesias Gonsálvez writes: > > > > It was setting XYWZ swizzle and

Re: [Mesa-dev] [PATCH v2 1/2] i965/vec4: fix swizzle and writemask when loading an uniform with constant offset

2017-05-02 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > El Viernes, 28 de abril de 2017 16:08:35 Francisco Jerez escribió: >> Samuel Iglesias Gonsálvez writes: >> > It was setting XYWZ swizzle and writemask to all uniforms, no matter if >> > they were a vector or scalar,

Re: [Mesa-dev] [PATCH v2 1/2] i965/vec4: fix swizzle and writemask when loading an uniform with constant offset

2017-05-01 Thread Samuel Iglesias Gonsálvez
El Viernes, 28 de abril de 2017 16:08:35 Francisco Jerez escribió: > Samuel Iglesias Gonsálvez writes: > > It was setting XYWZ swizzle and writemask to all uniforms, no matter if > > they were a vector or scalar, so this can lead to problems when loading > > them to the push

Re: [Mesa-dev] [PATCH v2 1/2] i965/vec4: fix swizzle and writemask when loading an uniform with constant offset

2017-04-28 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > It was setting XYWZ swizzle and writemask to all uniforms, no matter if they > were a vector or scalar, so this can lead to problems when loading them > to the push constant buffer. > > Moreover, 'shift' calculation was designed to

[Mesa-dev] [PATCH v2 1/2] i965/vec4: fix swizzle and writemask when loading an uniform with constant offset

2017-04-26 Thread Samuel Iglesias Gonsálvez
It was setting XYWZ swizzle and writemask to all uniforms, no matter if they were a vector or scalar, so this can lead to problems when loading them to the push constant buffer. Moreover, 'shift' calculation was designed to calculate the offset in DWORDS, but it doesn't take into account DFs, so