Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add a _mesa_active_fragment_shader_has_side_effects helper

2015-12-22 Thread Tapani Pälli
On 12/16/2015 10:59 AM, Iago Toral Quiroga wrote: Some drivers can disable the FS unit if there is nothing in the shader code that writes to an output (i.e. color, depth, etc). Right now, mesa has a function to check for atomic buffers and the i965 driver also checks for images. Refactor this

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add a _mesa_active_fragment_shader_has_side_effects helper

2015-12-22 Thread Samuel Iglesias Gonsálvez
On Tue, 2015-12-22 at 10:39 +0200, Tapani Pälli wrote: > > On 12/16/2015 10:59 AM, Iago Toral Quiroga wrote: > > Some drivers can disable the FS unit if there is nothing in the > > shader code > > that writes to an output (i.e. color, depth, etc). Right now, mesa > > has > > a function to check

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add a _mesa_active_fragment_shader_has_side_effects helper

2015-12-18 Thread Francisco Jerez
Iago Toral writes: > On Thu, 2015-12-17 at 16:29 +0200, Francisco Jerez wrote: >> Iago Toral Quiroga writes: >> >> > Some drivers can disable the FS unit if there is nothing in the shader code >> > that writes to an output (i.e. color, depth, etc). Right

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add a _mesa_active_fragment_shader_has_side_effects helper

2015-12-17 Thread Francisco Jerez
Iago Toral Quiroga writes: > Some drivers can disable the FS unit if there is nothing in the shader code > that writes to an output (i.e. color, depth, etc). Right now, mesa has > a function to check for atomic buffers and the i965 driver also checks for > images. Refactor

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add a _mesa_active_fragment_shader_has_side_effects helper

2015-12-17 Thread Iago Toral
On Thu, 2015-12-17 at 16:29 +0200, Francisco Jerez wrote: > Iago Toral Quiroga writes: > > > Some drivers can disable the FS unit if there is nothing in the shader code > > that writes to an output (i.e. color, depth, etc). Right now, mesa has > > a function to check for

[Mesa-dev] [PATCH v2 1/2] mesa: Add a _mesa_active_fragment_shader_has_side_effects helper

2015-12-16 Thread Iago Toral Quiroga
Some drivers can disable the FS unit if there is nothing in the shader code that writes to an output (i.e. color, depth, etc). Right now, mesa has a function to check for atomic buffers and the i965 driver also checks for images. Refactor this logic into a generic function that we can use for any