Re: [Mesa-dev] [PATCH v2 1/3] nir: Add a pass to lower vector phi nodes to scalar phi nodes

2015-01-27 Thread Jason Ekstrand
On Tue, Jan 27, 2015 at 2:01 PM, Eric Anholt wrote: > Jason Ekstrand writes: > > > On Mon, Jan 26, 2015 at 3:58 PM, Eric Anholt wrote: > > > >> Jason Ekstrand writes: > >> > >> > On Mon, Jan 26, 2015 at 11:21 AM, Eric Anholt > wrote: > >> > > >> >> Jason Ekstrand writes: > >> >> > + cas

Re: [Mesa-dev] [PATCH v2 1/3] nir: Add a pass to lower vector phi nodes to scalar phi nodes

2015-01-27 Thread Jason Ekstrand
oops, this should have been a v3 On Tue, Jan 27, 2015 at 1:32 PM, Jason Ekstrand wrote: > v2 Jason Ekstrand : > - Add better comments > - Use nir_ssa_dest_init and nir_src_for_ssa more places > - Fix some void * casts > --- > src/glsl/Makefile.sources | 1 + > src/glsl/nir/ni

Re: [Mesa-dev] [PATCH v2 1/3] nir: Add a pass to lower vector phi nodes to scalar phi nodes

2015-01-27 Thread Eric Anholt
Jason Ekstrand writes: > On Mon, Jan 26, 2015 at 3:58 PM, Eric Anholt wrote: > >> Jason Ekstrand writes: >> >> > On Mon, Jan 26, 2015 at 11:21 AM, Eric Anholt wrote: >> > >> >> Jason Ekstrand writes: >> >> > + case nir_instr_type_phi: { >> >> > + nir_phi_instr *src_phi = nir_inst

[Mesa-dev] [PATCH v2 1/3] nir: Add a pass to lower vector phi nodes to scalar phi nodes

2015-01-27 Thread Jason Ekstrand
v2 Jason Ekstrand : - Add better comments - Use nir_ssa_dest_init and nir_src_for_ssa more places - Fix some void * casts --- src/glsl/Makefile.sources | 1 + src/glsl/nir/nir.h | 2 + src/glsl/nir/nir_lower_phis_to_scalar.c | 251 +

Re: [Mesa-dev] [PATCH v2 1/3] nir: Add a pass to lower vector phi nodes to scalar phi nodes

2015-01-26 Thread Jason Ekstrand
On Mon, Jan 26, 2015 at 3:58 PM, Eric Anholt wrote: > Jason Ekstrand writes: > > > On Mon, Jan 26, 2015 at 11:21 AM, Eric Anholt wrote: > > > >> Jason Ekstrand writes: > >> > + case nir_instr_type_phi: { > >> > + nir_phi_instr *src_phi = nir_instr_as_phi(src_instr); > >> > + > >>

Re: [Mesa-dev] [PATCH v2 1/3] nir: Add a pass to lower vector phi nodes to scalar phi nodes

2015-01-26 Thread Eric Anholt
Jason Ekstrand writes: > On Mon, Jan 26, 2015 at 11:21 AM, Eric Anholt wrote: > >> Jason Ekstrand writes: >> > + case nir_instr_type_phi: { >> > + nir_phi_instr *src_phi = nir_instr_as_phi(src_instr); >> > + >> > + /* Insert an entry and mark it as scalarizable for now. Tha

Re: [Mesa-dev] [PATCH v2 1/3] nir: Add a pass to lower vector phi nodes to scalar phi nodes

2015-01-26 Thread Jason Ekstrand
On Mon, Jan 26, 2015 at 11:21 AM, Eric Anholt wrote: > Jason Ekstrand writes: > > diff --git a/src/glsl/nir/nir_lower_phis_to_scalar.c > b/src/glsl/nir/nir_lower_phis_to_scalar.c > > new file mode 100644 > > index 000..9f901d6 > > --- /dev/null > > +++ b/src/glsl/nir/nir_lower_phis_to_scalar

Re: [Mesa-dev] [PATCH v2 1/3] nir: Add a pass to lower vector phi nodes to scalar phi nodes

2015-01-26 Thread Connor Abbott
On Mon, Jan 26, 2015 at 2:21 PM, Eric Anholt wrote: > I just notied: When do I need to all nir_metadata_preserve()? I didn't > in my pass. It dirties all the metadata (topologically-sorted block indices, dominance info, liveness info, etc.) except the stuff you tell it to preserve via the flags.

Re: [Mesa-dev] [PATCH v2 1/3] nir: Add a pass to lower vector phi nodes to scalar phi nodes

2015-01-26 Thread Eric Anholt
Jason Ekstrand writes: > diff --git a/src/glsl/nir/nir_lower_phis_to_scalar.c > b/src/glsl/nir/nir_lower_phis_to_scalar.c > new file mode 100644 > index 000..9f901d6 > --- /dev/null > +++ b/src/glsl/nir/nir_lower_phis_to_scalar.c > @@ -0,0 +1,238 @@ > +/* > + * Copyright © 2014 Intel Corporat

Re: [Mesa-dev] [PATCH v2 1/3] nir: Add a pass to lower vector phi nodes to scalar phi nodes

2015-01-24 Thread Jason Ekstrand
On Sat, Jan 24, 2015 at 5:01 PM, Connor Abbott wrote: > On Sat, Jan 24, 2015 at 12:22 PM, Jason Ekstrand > wrote: > > > > On Jan 24, 2015 8:18 AM, "Connor Abbott" wrote: > >> > >> On Sat, Jan 24, 2015 at 1:00 AM, Jason Ekstrand > >> wrote: > >> > --- > >> > src/glsl/Makefile.sources

Re: [Mesa-dev] [PATCH v2 1/3] nir: Add a pass to lower vector phi nodes to scalar phi nodes

2015-01-24 Thread Connor Abbott
On Sat, Jan 24, 2015 at 12:22 PM, Jason Ekstrand wrote: > > On Jan 24, 2015 8:18 AM, "Connor Abbott" wrote: >> >> On Sat, Jan 24, 2015 at 1:00 AM, Jason Ekstrand >> wrote: >> > --- >> > src/glsl/Makefile.sources | 1 + >> > src/glsl/nir/nir.h | 2 + >> > s

Re: [Mesa-dev] [PATCH v2 1/3] nir: Add a pass to lower vector phi nodes to scalar phi nodes

2015-01-24 Thread Jason Ekstrand
On Jan 24, 2015 9:22 AM, "Jason Ekstrand" wrote: > > > On Jan 24, 2015 8:18 AM, "Connor Abbott" wrote: > > > > On Sat, Jan 24, 2015 at 1:00 AM, Jason Ekstrand wrote: > > > --- > > > src/glsl/Makefile.sources | 1 + > > > src/glsl/nir/nir.h | 2 + > > > src

Re: [Mesa-dev] [PATCH v2 1/3] nir: Add a pass to lower vector phi nodes to scalar phi nodes

2015-01-24 Thread Jason Ekstrand
On Jan 24, 2015 8:18 AM, "Connor Abbott" wrote: > > On Sat, Jan 24, 2015 at 1:00 AM, Jason Ekstrand wrote: > > --- > > src/glsl/Makefile.sources | 1 + > > src/glsl/nir/nir.h | 2 + > > src/glsl/nir/nir_lower_phis_to_scalar.c | 238 +

Re: [Mesa-dev] [PATCH v2 1/3] nir: Add a pass to lower vector phi nodes to scalar phi nodes

2015-01-24 Thread Connor Abbott
On Sat, Jan 24, 2015 at 1:00 AM, Jason Ekstrand wrote: > --- > src/glsl/Makefile.sources | 1 + > src/glsl/nir/nir.h | 2 + > src/glsl/nir/nir_lower_phis_to_scalar.c | 238 > > 3 files changed, 241 insertions(+) > create mo

[Mesa-dev] [PATCH v2 1/3] nir: Add a pass to lower vector phi nodes to scalar phi nodes

2015-01-23 Thread Jason Ekstrand
--- src/glsl/Makefile.sources | 1 + src/glsl/nir/nir.h | 2 + src/glsl/nir/nir_lower_phis_to_scalar.c | 238 3 files changed, 241 insertions(+) create mode 100644 src/glsl/nir/nir_lower_phis_to_scalar.c diff --git a/src/gls