Hi Gwan-yeong,
I'm fine with the conventions you suggested -- my main nit was with the
verbosity. The downside is you're going to have to downcast every single
time. Your call ..
On Mon, Oct 23, 2017 at 1:22 PM, Mun, Gwan-gyeong
wrote:
> Hi Emil and Gurchetan,
>
> Thank
Hi Emil and Gurchetan,
Thank you for reviewing the patches.
2017-10-20 6:18 GMT+09:00 Gurchetan Singh :
> De-duplicating and then trimming down works for me.
>
> On Thu, Oct 19, 2017 at 3:31 AM, Emil Velikov
> wrote:
>>
>> On 18 October
De-duplicating and then trimming down works for me.
On Thu, Oct 19, 2017 at 3:31 AM, Emil Velikov
wrote:
> On 18 October 2017 at 23:36, Gurchetan Singh
> wrote:
> >> Then again, I'd suggest keeping that as separate series. These patches
>
On 18 October 2017 at 23:36, Gurchetan Singh
wrote:
>> Then again, I'd suggest keeping that as separate series. These patches
>> started as a way to minimise the duplication we have in drivers/dri2.
>
> I'm fine with dri2_$action_$object. We can modify the existing
> Then again, I'd suggest keeping that as separate series. These patches
> started as a way to minimise the duplication we have in drivers/dri2.
I'm fine with dri2_$action_$object. We can modify the existing functions
later, but I recommend adopting more concise conventions in this patchset,
On 17 October 2017 at 21:38, Gurchetan Singh
wrote:
> The naming is verbose and somewhat inconsistent. We have:
>
> dri2_init_surface
> dri2_fini_surface
> dri2_egl_surface_alloc_local_buffer
> dri2_egl_surface_free_local_buffers
>
> I suggest you implement the
The naming is verbose and somewhat inconsistent. We have:
dri2_init_surface
dri2_fini_surface
dri2_egl_surface_alloc_local_buffer
dri2_egl_surface_free_local_buffers
I suggest you implement the following convention:
dri2_surface_init
dri2_surface_fini
dri2_surface_alloc_attachment (instead of
Hi Gwan-gyeong,
On 6 October 2017 at 22:38, Gwan-gyeong Mun wrote:
> To share common free outdated buffers and update size code.
> This compares width and height arguments with current egl surface dimension,
> if the compared surface dimension is differ, then it free local
To share common free outdated buffers and update size code.
This compares width and height arguments with current egl surface dimension,
if the compared surface dimension is differ, then it free local buffers and
updates dimension.
In preparation to adding of new platform which uses this helper.