Re: [Mesa-dev] [PATCH v2 10/10] swr: [rasterizer codegen] Fix windows build

2017-03-28 Thread Rowley, Timothy O
I’m going to drop patch 10 from the patchset for now. -Tim On Mar 27, 2017, at 9:42 PM, Kyriazis, George mailto:george.kyria...@intel.com>> wrote: Tried Depends(), but it doesn’t work all the time. There are some cases where it works, and some others where it doesn’t. I’ll need to investigat

Re: [Mesa-dev] [PATCH v2 10/10] swr: [rasterizer codegen] Fix windows build

2017-03-27 Thread Kyriazis, George
Tried Depends(), but it doesn’t work all the time. There are some cases where it works, and some others where it doesn’t. I’ll need to investigate more. Fix in a separate checkin later? George On Mar 27, 2017, at 8:38 PM, Rowley, Timothy O mailto:timothy.o.row...@intel.com>> wrote: On close

Re: [Mesa-dev] [PATCH v2 10/10] swr: [rasterizer codegen] Fix windows build

2017-03-27 Thread Rowley, Timothy O
On closer review of 10/10, I don’t like the approach taken here. You’ve added a —template argument to gen_backends.py, making it different from the rest of the scripts and actually running it with different parameters on automake and scons. Can’t you get scons to have the necessary dependency u

[Mesa-dev] [PATCH v2 10/10] swr: [rasterizer codegen] Fix windows build

2017-03-27 Thread George Kyriazis
Fix codegen build break that was introduced earlier v2: update rules for gen_knobs.cpp and gen_knobs.h --- src/gallium/drivers/swr/Makefile.am| 4 +-- src/gallium/drivers/swr/SConscript | 15 ++- .../drivers/swr/rasterizer/codegen/gen_backends.py | 30 +++