Re: [Mesa-dev] [PATCH v2 10/30] egl/dri2: rework dri2_make_current code flow

Yeah, looking at it a bit longer, it seems that the unbind behavior broke (again like Eric suggested). When you replaced that condition : unbind = (cctx == NULL && ddraw == NULL && rdraw == NULL); if (unbind || dri2_dpy->core->bindContext(cctx, ddraw, rdraw)) { By this : if (cctx || ddraw

Re: [Mesa-dev] [PATCH v2 10/30] egl/dri2: rework dri2_make_current code flow

Thanks a lot, The diff is a bit too complicated for me to tell how it's different. - Lionel On 14/10/16 16:11, Emil Velikov wrote: On 14 October 2016 at 15:58, Lionel Landwerlin wrote: Hi Emil, I've not been able to run the deqp gles31 test suite after this

Re: [Mesa-dev] [PATCH v2 10/30] egl/dri2: rework dri2_make_current code flow

On 14 October 2016 at 15:58, Lionel Landwerlin wrote: > Hi Emil, > > I've not been able to run the deqp gles31 test suite after this commit. > Like Eric suggested I think this is introducing a behavior change. > v2 should not do that, yet it might be missing

Re: [Mesa-dev] [PATCH v2 10/30] egl/dri2: rework dri2_make_current code flow

Hi Emil, I've not been able to run the deqp gles31 test suite after this commit. Like Eric suggested I think this is introducing a behavior change. Thanks, - Lionel On 03/10/16 19:28, Emil Velikov wrote: From: Emil Velikov Fold duplicate conditional blocks and

[Mesa-dev] [PATCH v2 10/30] egl/dri2: rework dri2_make_current code flow

From: Emil Velikov Fold duplicate conditional blocks and add a few extra comments ;-) v2: Bring back the explicit "unbind" logic (Eric), remove NULL derefs. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 72