Re: [Mesa-dev] [PATCH v2 11/12] nir: Add return lowering pass

2015-12-28 Thread Connor Abbott
On Mon, Dec 28, 2015 at 5:02 PM, Jason Ekstrand wrote: > > > On Mon, Dec 28, 2015 at 1:28 PM, Connor Abbott wrote: >> >> On Mon, Dec 28, 2015 at 4:21 PM, Jason Ekstrand >> wrote: >> >> >> >> >> >> but I hope you can get loops working soon so you can test this (and >> >> hey, loops are useful for

Re: [Mesa-dev] [PATCH v2 11/12] nir: Add return lowering pass

2015-12-28 Thread Jason Ekstrand
On Mon, Dec 28, 2015 at 1:28 PM, Connor Abbott wrote: > On Mon, Dec 28, 2015 at 4:21 PM, Jason Ekstrand > wrote: > >> > >> > >> but I hope you can get loops working soon so you can test this (and > >> hey, loops are useful for other things too :P). > > > > > > Yeah, I'm starting on adding a real

Re: [Mesa-dev] [PATCH v2 11/12] nir: Add return lowering pass

2015-12-28 Thread Connor Abbott
On Mon, Dec 28, 2015 at 4:21 PM, Jason Ekstrand wrote: >> >> >> but I hope you can get loops working soon so you can test this (and >> hey, loops are useful for other things too :P). > > > Yeah, I'm starting on adding a real CFG to spirv_to_nir today. It's the > task that I've had on my todo list

Re: [Mesa-dev] [PATCH v2 11/12] nir: Add return lowering pass

2015-12-28 Thread Jason Ekstrand
On Mon, Dec 28, 2015 at 12:40 PM, Connor Abbott wrote: > On Mon, Dec 28, 2015 at 2:29 AM, Jason Ekstrand > wrote: > > This commit adds a NIR pass for lowering away returns in functions. If > the > > return is in a loop, it is lowered to a break. If it is not in a loop, > > it's lowered away by

Re: [Mesa-dev] [PATCH v2 11/12] nir: Add return lowering pass

2015-12-28 Thread Connor Abbott
On Mon, Dec 28, 2015 at 2:29 AM, Jason Ekstrand wrote: > This commit adds a NIR pass for lowering away returns in functions. If the > return is in a loop, it is lowered to a break. If it is not in a loop, > it's lowered away by moving/deleting code as needed. > --- > src/glsl/Makefile.sources

[Mesa-dev] [PATCH v2 11/12] nir: Add return lowering pass

2015-12-27 Thread Jason Ekstrand
This commit adds a NIR pass for lowering away returns in functions. If the return is in a loop, it is lowered to a break. If it is not in a loop, it's lowered away by moving/deleting code as needed. --- src/glsl/Makefile.sources| 1 + src/glsl/nir/nir.h | 3 + src/glsl/