Re: [Mesa-dev] [PATCH v2 11/26] python: Fix rich comparisons

2018-08-07 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Mathieu Bridon (2018-07-17 13:57:39) > Python 3 doesn't call objects __cmp__() methods any more to compare > them. Instead, it requires implementing the rich comparison methods > explicitly: __eq__(), __ne(), __lt__(), __le__(), __gt__() and __ge__(). > >

[Mesa-dev] [PATCH v2 11/26] python: Fix rich comparisons

2018-07-17 Thread Mathieu Bridon
Python 3 doesn't call objects __cmp__() methods any more to compare them. Instead, it requires implementing the rich comparison methods explicitly: __eq__(), __ne(), __lt__(), __le__(), __gt__() and __ge__(). Fortunately Python 2 also supports those. This commit only implements the comparison