Re: [Mesa-dev] [PATCH v2 17/29] mesa/main/framebuffer.h: Fix one -Wsign-compare warning in ?: construct.

2017-11-23 Thread Emil Velikov
On 21 November 2017 at 10:47, Gert Wollny wrote: > Am Donnerstag, den 16.11.2017, 22:52 +0100 schrieb Gert Wollny: >> Am Donnerstag, den 16.11.2017, 17:13 + schrieb Emil Velikov: >> > >> > According to the spec both of these are 'Z + Non-negative integer >> > or enumerated value' Worth doing t

Re: [Mesa-dev] [PATCH v2 17/29] mesa/main/framebuffer.h: Fix one -Wsign-compare warning in ?: construct.

2017-11-21 Thread Gert Wollny
Am Donnerstag, den 16.11.2017, 22:52 +0100 schrieb Gert Wollny: > Am Donnerstag, den 16.11.2017, 17:13 + schrieb Emil Velikov: > > > > According to the spec both of these are 'Z + Non-negative integer > > or enumerated value' Worth doing that instead? > > After having a short look into it, I

Re: [Mesa-dev] [PATCH v2 17/29] mesa/main/framebuffer.h: Fix one -Wsign-compare warning in ?: construct.

2017-11-16 Thread Gert Wollny
Am Donnerstag, den 16.11.2017, 17:13 + schrieb Emil Velikov: > On 16 November 2017 at 15:09, Gert Wollny > wrote: > > Explicitely convert on value to the target type. > > > > Signed-off-by: Gert Wollny > > Reviewed-by: Brian Paul > > --- > >  src/mesa/main/framebuffer.h | 2 +- > >  1 file c

Re: [Mesa-dev] [PATCH v2 17/29] mesa/main/framebuffer.h: Fix one -Wsign-compare warning in ?: construct.

2017-11-16 Thread Emil Velikov
On 16 November 2017 at 15:09, Gert Wollny wrote: > Explicitely convert on value to the target type. > > Signed-off-by: Gert Wollny > Reviewed-by: Brian Paul > --- > src/mesa/main/framebuffer.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/main/framebuffer.h b

[Mesa-dev] [PATCH v2 17/29] mesa/main/framebuffer.h: Fix one -Wsign-compare warning in ?: construct.

2017-11-16 Thread Gert Wollny
Explicitely convert on value to the target type. Signed-off-by: Gert Wollny Reviewed-by: Brian Paul --- src/mesa/main/framebuffer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/framebuffer.h b/src/mesa/main/framebuffer.h index bc6e7bc31a..bffa21dcea 100644 -