Re: [Mesa-dev] [PATCH v2 2/3] anv/blorp: consider multiview and view masks for tracking pending clear aspects

On Wed, Jan 24, 2018 at 2:11 AM, Iago Toral wrote: > On Wed, 2018-01-24 at 01:51 -0800, Jason Ekstrand wrote: > > Thanks for the detailed explanation. I have a couple of comments: > > 1) This is going to conflict with some of the stuff I've got in-flight > that reworks

Re: [Mesa-dev] [PATCH v2 2/3] anv/blorp: consider multiview and view masks for tracking pending clear aspects

On Wed, 2018-01-24 at 01:51 -0800, Jason Ekstrand wrote: > Thanks for the detailed explanation. I have a couple of comments: > > 1) This is going to conflict with some of the stuff I've got in- > flight that reworks fast-clears significantly. I think it will make > everything easier if we land

Re: [Mesa-dev] [PATCH v2 2/3] anv/blorp: consider multiview and view masks for tracking pending clear aspects

Thanks for the detailed explanation. I have a couple of comments: 1) This is going to conflict with some of the stuff I've got in-flight that reworks fast-clears significantly. I think it will make everything easier if we land the reworks first. 2) It may be better to add a

Re: [Mesa-dev] [PATCH v2 2/3] anv/blorp: consider multiview and view masks for tracking pending clear aspects

That's a good question, I was asking this myself when I did this. The spec says: "loadOp is a VkAttachmentLoadOp value specifying how the contents of color and depth components of the attachment are treated at the beginning of the subpass where it is first used." So I figured the correct thing

Re: [Mesa-dev] [PATCH v2 2/3] anv/blorp: consider multiview and view masks for tracking pending clear aspects

Do we really want to wait until a subpass that uses the given view or do we just want to clear all of the relevant slices in the first subpass that touches it? I haven't really thought about this much. On Fri, Jan 5, 2018 at 8:38 AM, Iago Toral Quiroga wrote: > When

[Mesa-dev] [PATCH v2 2/3] anv/blorp: consider multiview and view masks for tracking pending clear aspects

When multiview is active a subpass clear may only clear a subset of the attachment layers. Other subpasses in the same render pass may also clear too and we want to honor those clears as well, however, we need to ensure that we only clear a layer once, on the first subpass that uses a particular