Re: [Mesa-dev] [PATCH v2 20/31] glsl: add _mesa_glsl_parse_state object to is_lvalue()

2017-04-26 Thread Nicolai Hähnle
On 26.04.2017 06:25, Timothy Arceri wrote: On 24/04/17 20:35, Samuel Pitoiset wrote: Yes, this is a bit hacky but we don't really have the choice. Plain GLSL doesn't accept bindless samplers/images as l-values while it's allowed when ARB_bindless_texture is enabled. Are you sure we need this?

Re: [Mesa-dev] [PATCH v2 20/31] glsl: add _mesa_glsl_parse_state object to is_lvalue()

2017-04-25 Thread Timothy Arceri
On 24/04/17 20:35, Samuel Pitoiset wrote: Yes, this is a bit hacky but we don't really have the choice. Plain GLSL doesn't accept bindless samplers/images as l-values while it's allowed when ARB_bindless_texture is enabled. Are you sure we need this? Can't we just set all the bindless

[Mesa-dev] [PATCH v2 20/31] glsl: add _mesa_glsl_parse_state object to is_lvalue()

2017-04-24 Thread Samuel Pitoiset
Yes, this is a bit hacky but we don't really have the choice. Plain GLSL doesn't accept bindless samplers/images as l-values while it's allowed when ARB_bindless_texture is enabled. The default NULL parameter is because we can't access the _mesa_glsl_parse_state object in few places in the