Re: [Mesa-dev] [PATCH v2 3/3] glsl: Use array deref for access to vector components

On 2015-11-11 20:57:55, Matt Turner wrote: > On Wed, Nov 11, 2015 at 8:47 PM, Ilia Mirkin wrote: > > On Nov 11, 2015 9:10 PM, "Matt Turner" wrote: > >> > >> On Thu, Nov 5, 2015 at 9:44 PM, Kristian Høgsberg Kristensen > >> wrote: >

Re: [Mesa-dev] [PATCH v2 3/3] glsl: Use array deref for access to vector components

On Wed, Nov 11, 2015 at 8:47 PM, Ilia Mirkin wrote: > On Nov 11, 2015 9:10 PM, "Matt Turner" wrote: >> >> On Thu, Nov 5, 2015 at 9:44 PM, Kristian Høgsberg Kristensen >> wrote: >> > diff --git a/src/glsl/ast_function.cpp

Re: [Mesa-dev] [PATCH v2 3/3] glsl: Use array deref for access to vector components

On Thu, Nov 5, 2015 at 9:44 PM, Kristian Høgsberg Kristensen wrote: > diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp > index e4e4a3f..5584470 100644 > --- a/src/glsl/ast_function.cpp > +++ b/src/glsl/ast_function.cpp > @@ -376,12 +368,8 @@

Re: [Mesa-dev] [PATCH v2 3/3] glsl: Use array deref for access to vector components

On Nov 11, 2015 9:10 PM, "Matt Turner" wrote: > > On Thu, Nov 5, 2015 at 9:44 PM, Kristian Høgsberg Kristensen > wrote: > > diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp > > index e4e4a3f..5584470 100644 > > ---

[Mesa-dev] [PATCH v2 3/3] glsl: Use array deref for access to vector components

We've assumed that we could lower per-component vector access from vec[i] = scalar to vec = ir_triop_vector_insert(vec, scalar, i) but with SSBOs (and compute shader SLM and tesselation outputs) this is no longer valid. If a vector is "externally visible", multiple threads can write