Re: [Mesa-dev] [PATCH v2 3/3] glsl: disable array splitting for AoA

2017-07-18 Thread Jason Ekstrand
I sent a replacement for patch 1. Patches 2 and 3 are Reviewed-by: Jason Ekstrand We should CC stable on my replacement for 1 and 2 because these affect Vulkan even without the AoA splitting patch. --Jason On Sat, Jul 15, 2017 at 12:48 AM, Timothy Arceri

Re: [Mesa-dev] [PATCH v2 3/3] glsl: disable array splitting for AoA

2017-07-15 Thread Timothy Arceri
On Mon, Jul 3, 2017, at 10:16 AM, Jason Ekstrand wrote: > I'd like the chance to look at these, please. I'm on vacation today and > tomorrow though. Ping! > > > On July 3, 2017 7:19:04 AM funfunc...@folklore1984.net wrote: > > > On 2017-07-03 08:47, Timothy Arceri wrote: > >> While it

Re: [Mesa-dev] [PATCH v2 3/3] glsl: disable array splitting for AoA

2017-07-03 Thread Jason Ekstrand
I'd like the chance to look at these, please. I'm on vacation today and tomorrow though. On July 3, 2017 7:19:04 AM funfunc...@folklore1984.net wrote: On 2017-07-03 08:47, Timothy Arceri wrote: While it produces functioning code the pass creates worse code for arrays of arrays. See the

Re: [Mesa-dev] [PATCH v2 3/3] glsl: disable array splitting for AoA

2017-07-03 Thread funfunctor
On 2017-07-03 08:47, Timothy Arceri wrote: While it produces functioning code the pass creates worse code for arrays of arrays. See the comment added in this patch for more detail. V2: skip splitting of AoA of matrices too. Reviewed-by: Edward O'Callaghan ---

[Mesa-dev] [PATCH v2 3/3] glsl: disable array splitting for AoA

2017-07-02 Thread Timothy Arceri
While it produces functioning code the pass creates worse code for arrays of arrays. See the comment added in this patch for more detail. V2: skip splitting of AoA of matrices too. --- src/compiler/glsl/opt_array_splitting.cpp | 23 +++ 1 file changed, 23 insertions(+) diff