Re: [Mesa-dev] [PATCH v2 3/8] nir: allow more nested loops to be unrolled

2018-08-17 Thread Jason Ekstrand
Thanks for the explanation and fixing the boolean mess Reviewed-by: Jason Ekstrand On Mon, Jul 23, 2018 at 3:02 AM Timothy Arceri wrote: > The innermost check was added to stop us from unrolling multiple > loops in a single pass, and to stop outer loops from unrolling. > > When we successfully

[Mesa-dev] [PATCH v2 3/8] nir: allow more nested loops to be unrolled

2018-07-23 Thread Timothy Arceri
The innermost check was added to stop us from unrolling multiple loops in a single pass, and to stop outer loops from unrolling. When we successfully unroll a loop we need to run the analysis pass again before deciding if we want to go ahead an unroll a second loop. However the logic was flawed b