Re: [Mesa-dev] [PATCH v2 56/59] i965/fs: push first double-based uniforms in push constant buffer

2016-05-09 Thread Francisco Jerez
Kenneth Graunke writes: > On Monday, May 9, 2016 7:33:02 AM PDT Samuel Iglesias Gonsálvez wrote: >> >> On 09/05/16 07:21, Pohjolainen, Topi wrote: >> > On Fri, May 06, 2016 at 08:56:08AM +0200, Samuel Iglesias Gons?lvez wrote: >> >> When there is a mix of definitions of uniforms with 32-bit or 6

Re: [Mesa-dev] [PATCH v2 56/59] i965/fs: push first double-based uniforms in push constant buffer

2016-05-08 Thread Pohjolainen, Topi
On Mon, May 09, 2016 at 07:33:02AM +0200, Samuel Iglesias Gons?lvez wrote: > > > On 09/05/16 07:21, Pohjolainen, Topi wrote: > > On Fri, May 06, 2016 at 08:56:08AM +0200, Samuel Iglesias Gons?lvez wrote: > >> When there is a mix of definitions of uniforms with 32-bit or 64-bit > >> data type size

Re: [Mesa-dev] [PATCH v2 56/59] i965/fs: push first double-based uniforms in push constant buffer

2016-05-08 Thread Kenneth Graunke
On Monday, May 9, 2016 7:33:02 AM PDT Samuel Iglesias Gonsálvez wrote: > > On 09/05/16 07:21, Pohjolainen, Topi wrote: > > On Fri, May 06, 2016 at 08:56:08AM +0200, Samuel Iglesias Gons?lvez wrote: > >> When there is a mix of definitions of uniforms with 32-bit or 64-bit > >> data type sizes, the

Re: [Mesa-dev] [PATCH v2 56/59] i965/fs: push first double-based uniforms in push constant buffer

2016-05-08 Thread Samuel Iglesias Gonsálvez
On 09/05/16 07:21, Pohjolainen, Topi wrote: > On Fri, May 06, 2016 at 08:56:08AM +0200, Samuel Iglesias Gons?lvez wrote: >> When there is a mix of definitions of uniforms with 32-bit or 64-bit >> data type sizes, the driver ends up doing misaligned access to double >> based variables in the push

Re: [Mesa-dev] [PATCH v2 56/59] i965/fs: push first double-based uniforms in push constant buffer

2016-05-08 Thread Pohjolainen, Topi
On Fri, May 06, 2016 at 08:56:08AM +0200, Samuel Iglesias Gons?lvez wrote: > When there is a mix of definitions of uniforms with 32-bit or 64-bit > data type sizes, the driver ends up doing misaligned access to double > based variables in the push constant buffer. > > To fix this, this patch pushe

Re: [Mesa-dev] [PATCH v2 56/59] i965/fs: push first double-based uniforms in push constant buffer

2016-05-08 Thread Samuel Iglesias Gonsálvez
On 07/05/16 09:22, Jordan Justen wrote: > On 2016-05-05 23:56:08, Samuel Iglesias Gonsálvez wrote: >> When there is a mix of definitions of uniforms with 32-bit or 64-bit >> data type sizes, the driver ends up doing misaligned access to double >> based variables in the push constant buffer. >> >>

Re: [Mesa-dev] [PATCH v2 56/59] i965/fs: push first double-based uniforms in push constant buffer

2016-05-07 Thread Jordan Justen
On 2016-05-05 23:56:08, Samuel Iglesias Gonsálvez wrote: > When there is a mix of definitions of uniforms with 32-bit or 64-bit > data type sizes, the driver ends up doing misaligned access to double > based variables in the push constant buffer. > > To fix this, this patch pushes first all the 64

Re: [Mesa-dev] [PATCH v2 56/59] i965/fs: push first double-based uniforms in push constant buffer

2016-05-06 Thread Samuel Iglesias Gonsálvez
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Kenneth gave his R-b to this patch on IRC: "i965/fs: push first double-based uniforms in push constant buffer" gets my R-b On 06/05/16 08:56, Samuel Iglesias Gonsálvez wrote: > When there is a mix of definitions of uniforms with 32-bit or > 64-bit

[Mesa-dev] [PATCH v2 56/59] i965/fs: push first double-based uniforms in push constant buffer

2016-05-05 Thread Samuel Iglesias Gonsálvez
When there is a mix of definitions of uniforms with 32-bit or 64-bit data type sizes, the driver ends up doing misaligned access to double based variables in the push constant buffer. To fix this, this patch pushes first all the 64-bit variables and then the rest. Then, all the variables would be