Re: [Mesa-dev] [PATCH v2 kmscube] cube-tex: Do not declare counter inside 'for' loop

2017-03-21 Thread Fabio Estevam
Hi Eric, On Tue, Mar 21, 2017 at 9:01 AM, Eric Engestrom wrote: > I think I'd prefer not going backwards. Does your compiler support C99? > If so, I'd suggest using it explicitly by adding -std=c99 to the CFLAGS > in Makefile.am. Yes, that works too. Just sent a

Re: [Mesa-dev] [PATCH v2 kmscube] cube-tex: Do not declare counter inside 'for' loop

2017-03-21 Thread Eric Engestrom
On Monday, 2017-03-20 09:33:50 -0300, Fabio Estevam wrote: > Do not declare counter inside 'for' loop to fix the following build errors > on mips64el: > > cube-tex.c: In function 'get_fd_rgba': > cube-tex.c:230:2: error: 'for' loop initial declarations are only allowed in > C99 mode > for

[Mesa-dev] [PATCH v2 kmscube] cube-tex: Do not declare counter inside 'for' loop

2017-03-20 Thread Fabio Estevam
Do not declare counter inside 'for' loop to fix the following build errors on mips64el: cube-tex.c: In function 'get_fd_rgba': cube-tex.c:230:2: error: 'for' loop initial declarations are only allowed in C99 mode for (uint32_t i = 0; i < texh; i++) { ^ cube-tex.c:230:2: note: use option