Re: [Mesa-dev] [PATCH v3] glsl/blob: avoid NULL ptr in blob_write_string/blob_read_string

2017-04-11 Thread Nicolai Hähnle
On 07.04.2017 21:45, gregory hainaut wrote: On Thu, 6 Apr 2017 00:21:19 +0200 gregory hainaut wrote: On Wed, 5 Apr 2017 14:22:00 -0400 Ilia Mirkin wrote: On Wed, Apr 5, 2017 at 1:12 PM, Gregory Hainaut wrote:

Re: [Mesa-dev] [PATCH v3] glsl/blob: avoid NULL ptr in blob_write_string/blob_read_string

2017-04-07 Thread gregory hainaut
On Thu, 6 Apr 2017 00:21:19 +0200 gregory hainaut wrote: > On Wed, 5 Apr 2017 14:22:00 -0400 > Ilia Mirkin wrote: > > > On Wed, Apr 5, 2017 at 1:12 PM, Gregory Hainaut > > wrote: > > > Context: > > > Nouveau uses NULL

Re: [Mesa-dev] [PATCH v3] glsl/blob: avoid NULL ptr in blob_write_string/blob_read_string

2017-04-05 Thread gregory hainaut
On Wed, 5 Apr 2017 14:22:00 -0400 Ilia Mirkin wrote: > On Wed, Apr 5, 2017 at 1:12 PM, Gregory Hainaut > wrote: > > Context: > > Nouveau uses NULL strings for unnamed parameter of texture gather > > offsets opcode. > > To be clear, this isn't a

Re: [Mesa-dev] [PATCH v3] glsl/blob: avoid NULL ptr in blob_write_string/blob_read_string

2017-04-05 Thread Ilia Mirkin
On Wed, Apr 5, 2017 at 1:12 PM, Gregory Hainaut wrote: > Context: > Nouveau uses NULL strings for unnamed parameter of texture gather > offsets opcode. To be clear, this isn't a "nouveau" thing, as it is well downstream of all this GLSL stuff. And FWIW

[Mesa-dev] [PATCH v3] glsl/blob: avoid NULL ptr in blob_write_string/blob_read_string

2017-04-05 Thread Gregory Hainaut
Context: Nouveau uses NULL strings for unnamed parameter of texture gather offsets opcode. Fix piglit crashes of the 'texturegatheroffsets' tests on Nouveau v3: Redo patch based on Nicolai/Timothy feedback Create dedicated blob_write_string_optional/blob_read_string_optional to handle null