Re: [Mesa-dev] [PATCH v3] nv50/ir: add debug options for shader replacement

2018-05-28 Thread Ilia Mirkin
Hi Rhys, I really like this in general, but I have some feedback on the specific implementation: 1. The shader and its header can be closely related. Please integrate something that also loads/dumps the shader header (separate file). This should go into nvc0_program, as that's where the header is

[Mesa-dev] [PATCH v3] nv50/ir: add debug options for shader replacement

2018-05-22 Thread Rhys Perry
Changes in v2: - move "#ifdef DEBUG" from above dumpProgram to above createDumpFilename Changes in v3: - Fixed messed up patch description and diff - Use the checksum of the TGSI instead of the binary if possible The NV50_PROG_DUMP environment variable specifies a (already created) directory to du