Re: [Mesa-dev] [PATCH v3 19/43] i965/fs: Support push constants of 16-bit types

2017-10-30 Thread Jason Ekstrand
On Thu, Oct 12, 2017 at 11:38 AM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > We enable the use of 16-bit values in push constants > modifying the assign_constant_locations function to work > with 16-bit types. > > The API to access buffers in Vulkan use multiples of 4-byte for >

Re: [Mesa-dev] [PATCH v3 19/43] i965/fs: Support push constants of 16-bit types

2017-10-30 Thread Pohjolainen, Topi
On Mon, Oct 30, 2017 at 05:10:53PM +0100, Chema Casanova wrote: > El 30/10/17 a las 07:44, Pohjolainen, Topi escribió: > > On Sun, Oct 29, 2017 at 11:17:11PM +0100, Chema Casanova wrote: > >> On 29/10/17 19:55, Pohjolainen, Topi wrote: > >>> On Thu, Oct 12, 2017 at 08:38:08PM +0200, Jose Maria

Re: [Mesa-dev] [PATCH v3 19/43] i965/fs: Support push constants of 16-bit types

2017-10-30 Thread Chema Casanova
El 30/10/17 a las 07:44, Pohjolainen, Topi escribió: > On Sun, Oct 29, 2017 at 11:17:11PM +0100, Chema Casanova wrote: >> On 29/10/17 19:55, Pohjolainen, Topi wrote: >>> On Thu, Oct 12, 2017 at 08:38:08PM +0200, Jose Maria Casanova Crespo wrote: We enable the use of 16-bit values in push

Re: [Mesa-dev] [PATCH v3 19/43] i965/fs: Support push constants of 16-bit types

2017-10-30 Thread Pohjolainen, Topi
On Sun, Oct 29, 2017 at 11:17:11PM +0100, Chema Casanova wrote: > On 29/10/17 19:55, Pohjolainen, Topi wrote: > > On Thu, Oct 12, 2017 at 08:38:08PM +0200, Jose Maria Casanova Crespo wrote: > >> We enable the use of 16-bit values in push constants > >> modifying the assign_constant_locations

Re: [Mesa-dev] [PATCH v3 19/43] i965/fs: Support push constants of 16-bit types

2017-10-29 Thread Chema Casanova
On 29/10/17 19:55, Pohjolainen, Topi wrote: > On Thu, Oct 12, 2017 at 08:38:08PM +0200, Jose Maria Casanova Crespo wrote: >> We enable the use of 16-bit values in push constants >> modifying the assign_constant_locations function to work >> with 16-bit types. >> >> The API to access buffers in

Re: [Mesa-dev] [PATCH v3 19/43] i965/fs: Support push constants of 16-bit types

2017-10-29 Thread Pohjolainen, Topi
On Thu, Oct 12, 2017 at 08:38:08PM +0200, Jose Maria Casanova Crespo wrote: > We enable the use of 16-bit values in push constants > modifying the assign_constant_locations function to work > with 16-bit types. > > The API to access buffers in Vulkan use multiples of 4-byte for > offsets and

Re: [Mesa-dev] [PATCH v3 19/43] i965/fs: Support push constants of 16-bit types

2017-10-14 Thread Chema Casanova
On 14/10/17 10:02, Pohjolainen, Topi wrote: > On Thu, Oct 12, 2017 at 08:38:08PM +0200, Jose Maria Casanova Crespo wrote: >> We enable the use of 16-bit values in push constants >> modifying the assign_constant_locations function to work >> with 16-bit types. >> >> The API to access buffers in

Re: [Mesa-dev] [PATCH v3 19/43] i965/fs: Support push constants of 16-bit types

2017-10-14 Thread Pohjolainen, Topi
On Thu, Oct 12, 2017 at 08:38:08PM +0200, Jose Maria Casanova Crespo wrote: > We enable the use of 16-bit values in push constants > modifying the assign_constant_locations function to work > with 16-bit types. > > The API to access buffers in Vulkan use multiples of 4-byte for > offsets and

[Mesa-dev] [PATCH v3 19/43] i965/fs: Support push constants of 16-bit types

2017-10-12 Thread Jose Maria Casanova Crespo
We enable the use of 16-bit values in push constants modifying the assign_constant_locations function to work with 16-bit types. The API to access buffers in Vulkan use multiples of 4-byte for offsets and sizes. Current accountability of uniforms based on 4-byte slots will work for 16-bit values