Re: [Mesa-dev] [PATCH v3 2/2] meta: Add a meta implementation of GL_ARB_clear_texture

2014-07-07 Thread Pohjolainen, Topi
On Fri, Jul 04, 2014 at 05:26:44PM +0100, Neil Roberts wrote: Here is version 3 of the glClearTexImage implementation. I figured out I could avoid the whole issue of preserving the glClearColor state by using glClearBuffer instead of glClear. I think the patch is a lot neater this way. I like

Re: [Mesa-dev] [PATCH v3 2/2] meta: Add a meta implementation of GL_ARB_clear_texture

2014-07-07 Thread Neil Roberts
Pohjolainen, Topi topi.pohjolai...@intel.com writes: Here in this function you use glClearBuffer*() and later on in cleartexsubimage_depth_stencil() you use _mesa_ClearBuffer*() - I would switch to the latter here also. Ah, whoops, yes, sorry about that. I'll fix it up in the Git branch.

[Mesa-dev] [PATCH v3 2/2] meta: Add a meta implementation of GL_ARB_clear_texture

2014-07-04 Thread Neil Roberts
Here is version 3 of the glClearTexImage implementation. I figured out I could avoid the whole issue of preserving the glClearColor state by using glClearBuffer instead of glClear. I think the patch is a lot neater this way. I also fixed using sRGB textures and explicitly disabled dithering. -