Re: [Mesa-dev] [PATCH v3 21/34] i965: add initial implementation of on disk shader cache

2017-10-29 Thread Kenneth Graunke
On Sunday, October 22, 2017 1:01:29 PM PDT Jordan Justen wrote: > From: Timothy Arceri > > This uses the recently-added disk_cache.c to write out the final > linked binary for vertex and fragment shader programs. > > This is based off the initial implementation

Re: [Mesa-dev] [PATCH v3 21/34] i965: add initial implementation of on disk shader cache

2017-10-24 Thread Jason Ekstrand
looks good On Tue, Oct 24, 2017 at 12:06 AM, Jordan Justen wrote: > On 2017-10-23 19:48:51, Jason Ekstrand wrote: > > > > On Sun, Oct 22, 2017 at 1:01 PM, Jordan Justen < > jordan.l.jus...@intel.com> > > wrote: > > > > > + #define SET_UPLOAD_PARAMS(sh, sh_caps,

Re: [Mesa-dev] [PATCH v3 21/34] i965: add initial implementation of on disk shader cache

2017-10-24 Thread Jordan Justen
On 2017-10-23 19:48:51, Jason Ekstrand wrote: > > On Sun, Oct 22, 2017 at 1:01 PM, Jordan Justen > wrote: > > > + #define SET_UPLOAD_PARAMS(sh, sh_caps, prog) \ > > + do { \ > > +

Re: [Mesa-dev] [PATCH v3 21/34] i965: add initial implementation of on disk shader cache

2017-10-23 Thread Jason Ekstrand
I made one minor comment below. Reviewed-by: Jason Ekstrand On Sun, Oct 22, 2017 at 1:01 PM, Jordan Justen wrote: > From: Timothy Arceri > > This uses the recently-added disk_cache.c to write out the final >

[Mesa-dev] [PATCH v3 21/34] i965: add initial implementation of on disk shader cache

2017-10-22 Thread Jordan Justen
From: Timothy Arceri This uses the recently-added disk_cache.c to write out the final linked binary for vertex and fragment shader programs. This is based off the initial implementation done by Carl Worth. v2: * Squash 'i965: add image param shader cache support'