Re: [Mesa-dev] [PATCH v4] i965/vec4: check swizzle before discarding a uniform on a 3src operand

Reviewed-by: Matt Turner Thanks! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v4] i965/vec4: check swizzle before discarding a uniform on a 3src operand

Without this commit, copy propagation is discarded if it involves a uniform with an instruction that has 3 sources. But 3 sourced instructions can access scalar values. For example, this is what vec4_visitor::fix_3src_operand() is already doing: if (src.file == UNIFORM &&

Re: [Mesa-dev] [PATCH v4] i965/vec4: check swizzle before discarding a uniform on a 3src operand

On Thu, Sep 24, 2015 at 11:54 AM, Alejandro Piñeiro wrote: > Without this commit, copy propagation is discarded if it involves > a uniform with an instruction that has 3 sources. But 3 sourced > instructions can access scalar values. > > For example, this is what