Re: [Mesa-dev] [PATCH v4] swr: Refactor checks for compiler feature flags

2016-07-01 Thread Emil Velikov
On 1 July 2016 at 16:03, Chuck Atkins wrote: >> This part should have been a separate patch. Please try to keep things >> separate for the future. > > > Indeed, I should have this as two separate commits, one to encapsulate the > flag test and another to add additional

Re: [Mesa-dev] [PATCH v4] swr: Refactor checks for compiler feature flags

2016-07-01 Thread Chuck Atkins
> > This part should have been a separate patch. Please try to keep things > separate for the future. > Indeed, I should have this as two separate commits, one to encapsulate the flag test and another to add additional options to test for. I'll keep them more segmented in the future. > Esp

Re: [Mesa-dev] [PATCH v4] swr: Refactor checks for compiler feature flags

2016-07-01 Thread Emil Velikov
Hi Chuck, On 28 June 2016 at 20:50, Chuck Atkins wrote: > Encapsulate the test for which flags are needed to get a compiler to > support certain features. Along with this, give various options to try > for AVX and AVX2 support. Ideally we want to use specific

Re: [Mesa-dev] [PATCH v4] swr: Refactor checks for compiler feature flags

2016-06-29 Thread Rowley, Timothy O
Tested on gcc-5.3.1, clang-3.8, icc-16.0.3 Reviewed-by: Tim Rowley Tested-by: Tim Rowley > On Jun 28, 2016, at 2:50 PM, Chuck Atkins wrote: > > Encapsulate the test for which flags are needed to get a compiler

[Mesa-dev] [PATCH v4] swr: Refactor checks for compiler feature flags

2016-06-28 Thread Chuck Atkins
Encapsulate the test for which flags are needed to get a compiler to support certain features. Along with this, give various options to try for AVX and AVX2 support. Ideally we want to use specific instruction set feature flags, like -mavx2 for instance instead of -march=haswell, but the flags