Re: [Mesa-dev] [PATCH v4] virgl: Add support for glGetMultisample

2018-07-10 Thread Dave Airlie
On 10 July 2018 at 16:57, David Airlie wrote: > > > On Tue, Jul 10, 2018 at 4:44 PM, Gert Wollny > wrote: >> >> Am Dienstag, den 10.07.2018, 09:19 +1000 schrieb Dave Airlie: >> > >> > Just FYI in future please don't push mesa patches until the renderer >> > side patch has landed, this is to avoid

Re: [Mesa-dev] [PATCH v4] virgl: Add support for glGetMultisample

2018-07-09 Thread David Airlie
On Tue, Jul 10, 2018 at 4:44 PM, Gert Wollny wrote: > Am Dienstag, den 10.07.2018, 09:19 +1000 schrieb Dave Airlie: > > > > Just FYI in future please don't push mesa patches until the renderer > > side patch has landed, this is to avoid the abi accidentally > > diverging around the caps. > Sure,

Re: [Mesa-dev] [PATCH v4] virgl: Add support for glGetMultisample

2018-07-09 Thread Gert Wollny
Am Dienstag, den 10.07.2018, 09:19 +1000 schrieb Dave Airlie: > > Just FYI in future please don't push mesa patches until the renderer > side patch has landed, this is to avoid the abi accidentally > diverging around the caps. Sure, I'll keep that in mind, and sorry for rushing to push this. How

Re: [Mesa-dev] [PATCH v4] virgl: Add support for glGetMultisample

2018-07-09 Thread Dave Airlie
On 29 June 2018 at 20:57, Erik Faye-Lund wrote: > On Fri, Jun 29, 2018 at 12:52 PM Erik Faye-Lund wrote: >> >> On Fri, Jun 29, 2018 at 12:39 PM Gert Wollny >> wrote: >> > >> > Use caps to obtain the multisample sample positions for up to 16 >> > positions and implement the according Gallium int

Re: [Mesa-dev] [PATCH v4] virgl: Add support for glGetMultisample

2018-06-29 Thread Erik Faye-Lund
On Fri, Jun 29, 2018 at 12:52 PM Erik Faye-Lund wrote: > > On Fri, Jun 29, 2018 at 12:39 PM Gert Wollny > wrote: > > > > Use caps to obtain the multisample sample positions for up to 16 > > positions and implement the according Gallium interface. > > > > This implemenation (plus its counterpart

Re: [Mesa-dev] [PATCH v4] virgl: Add support for glGetMultisample

2018-06-29 Thread Erik Faye-Lund
On Fri, Jun 29, 2018 at 12:39 PM Gert Wollny wrote: > > Use caps to obtain the multisample sample positions for up to 16 > positions and implement the according Gallium interface. > > This implemenation (plus its counterpart in virglrenderer) assume that > the fixed sample position are always the

[Mesa-dev] [PATCH v4] virgl: Add support for glGetMultisample

2018-06-29 Thread Gert Wollny
Use caps to obtain the multisample sample positions for up to 16 positions and implement the according Gallium interface. This implemenation (plus its counterpart in virglrenderer) assume that the fixed sample position are always the same for a given number of samples over the whole live time of a