Re: [Mesa-dev] [PATCH v4 (part2) 46/59] glsl: Allow use of memory qualifiers with ARB_shader_storage_buffer_object.

On 13/08/15 10:05, Tapani Pälli wrote: Hi; I believe something more needs to be done here, it may be generic changes to the memory qualifier parsing. I wrote a Piglit test that fails with these changes (I tested against itoral-ARB_shader_storage_buffer_object-v4.1 branch), here:

Re: [Mesa-dev] [PATCH v4 (part2) 46/59] glsl: Allow use of memory qualifiers with ARB_shader_storage_buffer_object.

Hi; I believe something more needs to be done here, it may be generic changes to the memory qualifier parsing. I wrote a Piglit test that fails with these changes (I tested against itoral-ARB_shader_storage_buffer_object-v4.1 branch), here:

Re: [Mesa-dev] [PATCH v4 (part2) 46/59] glsl: Allow use of memory qualifiers with ARB_shader_storage_buffer_object.

Thanks Tapani, I'll look into this as soon as I get back from holidays. The implementation has changed slightly since I sent these patches too btw. Iago El 2015-08-13 10:05, Tapani Pälli escribió: Hi; I believe something more needs to be done here, it may be generic changes to the memory

[Mesa-dev] [PATCH v4 (part2) 46/59] glsl: Allow use of memory qualifiers with ARB_shader_storage_buffer_object.

--- src/glsl/glsl_lexer.ll | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/glsl/glsl_lexer.ll b/src/glsl/glsl_lexer.ll index efa0bb6..b9d700a 100644 --- a/src/glsl/glsl_lexer.ll +++ b/src/glsl/glsl_lexer.ll @@ -405,11 +405,11 @@ image2DShadow