On Fri, Jun 1, 2018 at 4:51 PM, Jason Ekstrand wrote:
> Can you give me an exact CI test name? I ran exactly this branch through
> our CI prior to sending it out and everything passed which is really weird
> given that this is happening at a fairly high level in NIR. I think I have
> some
Actually something post inlining that actually shows the problem:
shader: MESA_SHADER_COMPUTE
local-size: 1, 1, 1
shared-size: 1
inputs: 0
outputs: 0
uniforms: 0
shared: 0
decl_var uniform INTERP_MODE_NONE sampler2D @0 (0, 0, 0)
decl_var uniform INTERP_MODE_NONE sampler @1 (0, 0, 1)
decl_var
The casts are not lowered away in some of the CTS tests for radv:
shader: MESA_SHADER_COMPUTE
local-size: 1, 1, 1
shared-size: 1
inputs: 0
outputs: 0
uniforms: 0
shared: 0
decl_var uniform INTERP_MODE_NONE sampler2D @0 (0, 0, 0)
decl_var uniform INTERP_MODE_NONE sampler2D @1 (0, 0, 1)
decl_var
This commit completely reworks function calls in NIR. Instead of having
a set of variables for the parameters and return value, nir_call_instr
now has simply has a number of sources which get mapped to load_param
intrinsics inside the functions. It's up to the client API to build an
ABI on top
