Re: [Mesa-dev] [PATCH v4 2/4] util/ralloc: Don't define assert with magic member without DEBUG

2017-09-27 Thread Dylan Baker
Quoting Eric Engestrom (2017-09-27 04:10:37) > On Tuesday, 2017-09-26 23:38:11 +, Dylan Baker wrote: > > It is possible to have DEBUG disabled but asserts on (NDEBUG(, which > > parentheses typo > > other than that: > Reviewed-by: Eric Engestrom > > and I think you should've pushed these fi

Re: [Mesa-dev] [PATCH v4 2/4] util/ralloc: Don't define assert with magic member without DEBUG

2017-09-27 Thread Eric Engestrom
On Tuesday, 2017-09-26 23:38:11 +, Dylan Baker wrote: > It is possible to have DEBUG disabled but asserts on (NDEBUG(, which parentheses typo other than that: Reviewed-by: Eric Engestrom and I think you should've pushed these first two patches instead of carrying them in your unrelated meso

[Mesa-dev] [PATCH v4 2/4] util/ralloc: Don't define assert with magic member without DEBUG

2017-09-26 Thread Dylan Baker
It is possible to have DEBUG disabled but asserts on (NDEBUG(, which cannot build because these asserts work on members that are only present when DEBUG is on. Reviewed-by: Kenneth Graunke Signed-off-by: Dylan Baker --- src/util/ralloc.c | 8 1 file changed, 8 insertions(+) diff --git