Re: [Mesa-dev] [PATCH v4 23/44] i965/fs: Enables 16-bit load_ubo with sampler (v2)

2017-12-05 Thread Jason Ekstrand
Looks good to me. On Tue, Dec 5, 2017 at 3:47 PM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > From: Jason Ekstrand > > load_ubo is using 32-bit loads as uniforms surfaces have a 32-bit > surface format defined. So when reading 16-bit components with the > sampler we need to unsh

[Mesa-dev] [PATCH v4 23/44] i965/fs: Enables 16-bit load_ubo with sampler (v2)

2017-12-05 Thread Jose Maria Casanova Crespo
From: Jason Ekstrand load_ubo is using 32-bit loads as uniforms surfaces have a 32-bit surface format defined. So when reading 16-bit components with the sampler we need to unshuffle two 16-bit components from each 32-bit component. Using the sampler avoids the use of the byte_scattered_read mes

Re: [Mesa-dev] [PATCH v4 23/44] i965/fs: Enables 16-bit load_ubo with sampler

2017-12-05 Thread Chema Casanova
On 05/12/17 22:25, Chema Casanova wrote: > On 05/12/17 19:53, Jason Ekstrand wrote: >> On Tue, Dec 5, 2017 at 9:08 AM, Chema Casanova > > wrote: >> >> El 30/11/17 a las 23:58, Jason Ekstrand escribió: >> > On Wed, Nov 29, 2017 at 6:50 PM, Jose Maria Casanova

Re: [Mesa-dev] [PATCH v4 23/44] i965/fs: Enables 16-bit load_ubo with sampler

2017-12-05 Thread Chema Casanova
On 05/12/17 19:53, Jason Ekstrand wrote: > On Tue, Dec 5, 2017 at 9:08 AM, Chema Casanova > wrote: > > El 30/11/17 a las 23:58, Jason Ekstrand escribió: > > On Wed, Nov 29, 2017 at 6:50 PM, Jose Maria Casanova Crespo > > mailto:jmcasan...@igalia.com> >

Re: [Mesa-dev] [PATCH v4 23/44] i965/fs: Enables 16-bit load_ubo with sampler

2017-12-05 Thread Jason Ekstrand
On Tue, Dec 5, 2017 at 9:08 AM, Chema Casanova wrote: > El 30/11/17 a las 23:58, Jason Ekstrand escribió: > > On Wed, Nov 29, 2017 at 6:50 PM, Jose Maria Casanova Crespo > > mailto:jmcasan...@igalia.com>> wrote: > > > > load_ubo is using 32-bit loads as uniforms surfaces have a 32-bit > >

Re: [Mesa-dev] [PATCH v4 23/44] i965/fs: Enables 16-bit load_ubo with sampler

2017-12-05 Thread Chema Casanova
El 30/11/17 a las 23:58, Jason Ekstrand escribió: > On Wed, Nov 29, 2017 at 6:50 PM, Jose Maria Casanova Crespo > mailto:jmcasan...@igalia.com>> wrote: > > load_ubo is using 32-bit loads as uniforms surfaces have a 32-bit > surface format defined. So when reading 16-bit components with the

Re: [Mesa-dev] [PATCH v4 23/44] i965/fs: Enables 16-bit load_ubo with sampler

2017-11-30 Thread Jason Ekstrand
On Wed, Nov 29, 2017 at 6:50 PM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > load_ubo is using 32-bit loads as uniforms surfaces have a 32-bit > surface format defined. So when reading 16-bit components with the > sampler we need to unshuffle two 16-bit components from each 32-bit

[Mesa-dev] [PATCH v4 23/44] i965/fs: Enables 16-bit load_ubo with sampler

2017-11-29 Thread Jose Maria Casanova Crespo
load_ubo is using 32-bit loads as uniforms surfaces have a 32-bit surface format defined. So when reading 16-bit components with the sampler we need to unshuffle two 16-bit components from each 32-bit component. Using the sampler avoids the use of the byte_scattered_read message that needs one mes