On 25 September 2015 12:54:38 am AEST, "Samuel Iglesias Gonsálvez"
wrote:
>
>
>On 24/09/15 02:04, Timothy Arceri wrote:
>> On Wed, 2015-09-23 at 17:02 +0200, Antía Puentes wrote:
>>> Hi! Timothy,
>>> thanks for your review.
>>>
>>> Seeing your patch in:
>>>
>http://lists.freedesktop.org/archive
On 24/09/15 02:04, Timothy Arceri wrote:
> On Wed, 2015-09-23 at 17:02 +0200, Antía Puentes wrote:
>> Hi! Timothy,
>> thanks for your review.
>>
>> Seeing your patch in:
>> http://lists.freedesktop.org/archives/mesa-dev/2015-September/095070.
>> html
>>
>> The condition in my patch:
>> (var->type
On Wed, 2015-09-23 at 17:02 +0200, Antía Puentes wrote:
> Hi! Timothy,
> thanks for your review.
>
> Seeing your patch in:
> http://lists.freedesktop.org/archives/mesa-dev/2015-September/095070.
> html
>
> The condition in my patch:
> (var->type->interface_packing != GLSL_INTERFACE_PACKING_PACKED
Hi! Timothy,
thanks for your review.
Seeing your patch in:
http://lists.freedesktop.org/archives/mesa-dev/2015-September/095070.html
The condition in my patch:
(var->type->interface_packing != GLSL_INTERFACE_PACKING_PACKED)
should also be changed to:
(var->get_interface_type()->interface_packing
On Wed, 2015-09-23 at 12:25 +0200, Samuel Iglesias Gonsálvez wrote:
>
> On 21/09/15 13:11, Samuel Iglesias Gonsálvez wrote:
> > On 21/09/15 09:41, Tapani Pälli wrote:
> > > Seems like a nice fix, takes ES3 CTS failures from 116 to 64 on
> > > Haswell
> > > (most failing tests are with ubos).
> > >
On 21/09/15 13:11, Samuel Iglesias Gonsálvez wrote:
> On 21/09/15 09:41, Tapani Pälli wrote:
>> Seems like a nice fix, takes ES3 CTS failures from 116 to 64 on Haswell
>> (most failing tests are with ubos).
>>
>> Tested-by: Tapani Pälli
>>
>
> OK thanks!
>
>> This is individual patch not relat
On 21/09/15 09:41, Tapani Pälli wrote:
> Seems like a nice fix, takes ES3 CTS failures from 116 to 64 on Haswell
> (most failing tests are with ubos).
>
> Tested-by: Tapani Pälli
>
OK thanks!
> This is individual patch not related to just SSBOs, maybe this could be
> pushed separately from the
Seems like a nice fix, takes ES3 CTS failures from 116 to 64 on Haswell
(most failing tests are with ubos).
Tested-by: Tapani Pälli
This is individual patch not related to just SSBOs, maybe this could be
pushed separately from the rest?
// Tapani
On 09/10/2015 04:36 PM, Iago Toral Quiroga
From: Antia Puentes
Commit 1ca25ab (glsl: Do not eliminate 'shared' or 'std140' blocks
or block members) considered as active 'shared' and 'std140' uniform
blocks and uniform block arrays, but did not include the block array
elements. Because of that, it was possible to have an active uniform
blo
