Re: [Mesa-dev] [RFC] [PATCH 1/2] mesa: let GL3 buf obj queries not depend on opengl major version

2012-02-29 Thread Yuanhan Liu
On Wed, Feb 29, 2012 at 08:41:45AM -0800, Jose Fonseca wrote: > Yuanhan, > > Let's commit this. I think that was the consensus. > > Without it it will be extremely hard to get apitrace to accurately track > recursive buffer mappings w/ 2.x, as described in > https://github.com/apitrace/apitrace

Re: [Mesa-dev] [RFC] [PATCH 1/2] mesa: let GL3 buf obj queries not depend on opengl major version

2012-02-29 Thread Jose Fonseca
Yuanhan, Let's commit this. I think that was the consensus. Without it it will be extremely hard to get apitrace to accurately track recursive buffer mappings w/ 2.x, as described in https://github.com/apitrace/apitrace/issues/66 . I'll try to keep apitrace working correctly without these quer

Re: [Mesa-dev] [RFC] [PATCH 1/2] mesa: let GL3 buf obj queries not depend on opengl major version

2011-09-22 Thread Yuanhan Liu
On Mon, Sep 19, 2011 at 06:25:54PM +0800, Yuanhan Liu wrote: > If I understand correctly, the new GL3 buffer object queries parameters, > like BUFFER_MAP_ACCESS_FLAGS, depends on ARB_map_buffer_range > extension. Hello, Any more comments? BTW, it doesn't make sense for me that we can set the acc

Re: [Mesa-dev] [RFC] [PATCH 1/2] mesa: let GL3 buf obj queries not depend on opengl major version

2011-09-19 Thread Yuanhan Liu
On Mon, Sep 19, 2011 at 09:17:42AM -0700, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 09/19/2011 07:20 AM, Brian Paul wrote: > > On 09/19/2011 04:25 AM, Yuanhan Liu wrote: > >> If I understand correctly, the new GL3 buffer object queries > >> parameters, like BUFFE

Re: [Mesa-dev] [RFC] [PATCH 1/2] mesa: let GL3 buf obj queries not depend on opengl major version

2011-09-19 Thread Chris Bandy
On 09/19/2011 12:12 PM, Jose Fonseca wrote: > - Original Message - >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 09/19/2011 07:20 AM, Brian Paul wrote: >>> On 09/19/2011 04:25 AM, Yuanhan Liu wrote: If I understand correctly, the new GL3 buffer object queries parame

Re: [Mesa-dev] [RFC] [PATCH 1/2] mesa: let GL3 buf obj queries not depend on opengl major version

2011-09-19 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/19/2011 10:12 AM, Jose Fonseca wrote: > - Original Message - >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> On 09/19/2011 07:20 AM, Brian Paul wrote: >>> On 09/19/2011 04:25 AM, Yuanhan Liu wrote: If I understand correctly,

Re: [Mesa-dev] [RFC] [PATCH 1/2] mesa: let GL3 buf obj queries not depend on opengl major version

2011-09-19 Thread Brian Paul
On 09/19/2011 10:17 AM, Ian Romanick wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/19/2011 07:20 AM, Brian Paul wrote: On 09/19/2011 04:25 AM, Yuanhan Liu wrote: If I understand correctly, the new GL3 buffer object queries parameters, like BUFFER_MAP_ACCESS_FLAGS, depends on ARB_m

Re: [Mesa-dev] [RFC] [PATCH 1/2] mesa: let GL3 buf obj queries not depend on opengl major version

2011-09-19 Thread Jose Fonseca
- Original Message - > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 09/19/2011 07:20 AM, Brian Paul wrote: > > On 09/19/2011 04:25 AM, Yuanhan Liu wrote: > >> If I understand correctly, the new GL3 buffer object queries > >> parameters, like BUFFER_MAP_ACCESS_FLAGS, depends on >

Re: [Mesa-dev] [RFC] [PATCH 1/2] mesa: let GL3 buf obj queries not depend on opengl major version

2011-09-19 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/19/2011 07:20 AM, Brian Paul wrote: > On 09/19/2011 04:25 AM, Yuanhan Liu wrote: >> If I understand correctly, the new GL3 buffer object queries >> parameters, like BUFFER_MAP_ACCESS_FLAGS, depends on >> ARB_map_buffer_range extension. > > That

Re: [Mesa-dev] [RFC] [PATCH 1/2] mesa: let GL3 buf obj queries not depend on opengl major version

2011-09-19 Thread Brian Paul
On 09/19/2011 04:25 AM, Yuanhan Liu wrote: If I understand correctly, the new GL3 buffer object queries parameters, like BUFFER_MAP_ACCESS_FLAGS, depends on ARB_map_buffer_range extension. That would make sense, but in fact the extension spec (http://www.opengl.org/registry/specs/ARB/map_buffe

[Mesa-dev] [RFC] [PATCH 1/2] mesa: let GL3 buf obj queries not depend on opengl major version

2011-09-19 Thread Yuanhan Liu
If I understand correctly, the new GL3 buffer object queries parameters, like BUFFER_MAP_ACCESS_FLAGS, depends on ARB_map_buffer_range extension. Signed-off-by: Yuanhan Liu --- src/mesa/main/bufferobj.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/