Re: [Mesa-dev] [RFC] i965/dbg: Expose cases hitting a presumably dead optimization

2016-03-12 Thread Pohjolainen, Topi
On Sat, Mar 12, 2016 at 08:44:54AM -0800, Jason Ekstrand wrote: >On Mar 11, 2016 11:47 PM, "Pohjolainen, Topi" ><[1]topi.pohjolai...@intel.com> wrote: >> >> On Fri, Mar 11, 2016 at 05:59:37PM -0800, Jason Ekstrand wrote: >> >On Fri, Mar 11, 2016 at 4:40 AM, Topi Pohjolainen

Re: [Mesa-dev] [RFC] i965/dbg: Expose cases hitting a presumably dead optimization

2016-03-12 Thread Jason Ekstrand
On Mar 11, 2016 11:47 PM, "Pohjolainen, Topi" wrote: > > On Fri, Mar 11, 2016 at 05:59:37PM -0800, Jason Ekstrand wrote: > >On Fri, Mar 11, 2016 at 4:40 AM, Topi Pohjolainen > ><[1]topi.pohjolai...@intel.com> wrote: > > > > The logic iterates over param[]

Re: [Mesa-dev] [RFC] i965/dbg: Expose cases hitting a presumably dead optimization

2016-03-11 Thread Pohjolainen, Topi
On Fri, Mar 11, 2016 at 05:59:37PM -0800, Jason Ekstrand wrote: >On Fri, Mar 11, 2016 at 4:40 AM, Topi Pohjolainen ><[1]topi.pohjolai...@intel.com> wrote: > > The logic iterates over param[] which contains pointers to > uniform storage set during linking (see >

Re: [Mesa-dev] [RFC] i965/dbg: Expose cases hitting a presumably dead optimization

2016-03-11 Thread Jason Ekstrand
On Fri, Mar 11, 2016 at 4:40 AM, Topi Pohjolainen < topi.pohjolai...@intel.com> wrote: > The logic iterates over param[] which contains pointers to > uniform storage set during linking (see > link_assign_uniform_locations()). > > The pointers are unique and it should be impossible to find >

[Mesa-dev] [RFC] i965/dbg: Expose cases hitting a presumably dead optimization

2016-03-11 Thread Topi Pohjolainen
The logic iterates over param[] which contains pointers to uniform storage set during linking (see link_assign_uniform_locations()). The pointers are unique and it should be impossible to find matching entries. I couldn't find any regressions with test system. In addition I tried several