Re: [Mesa-dev] [RFC] nir/validate: on failure, dump shader w/ offending line annotated

2016-05-13 Thread Rob Clark
On Fri, May 13, 2016 at 9:13 PM, Connor Abbott wrote: > On Fri, May 13, 2016 at 9:07 PM, Rob Clark wrote: >> On Fri, May 13, 2016 at 8:23 PM, Connor Abbott wrote: >>> On Fri, May 13, 2016 at 4:14 PM, Rob Clark wrote: On Fri, May 13, 2016 at 4:10 PM, Jason Ekstrand wrote: > On Fr

Re: [Mesa-dev] [RFC] nir/validate: on failure, dump shader w/ offending line annotated

2016-05-13 Thread Connor Abbott
On Fri, May 13, 2016 at 9:07 PM, Rob Clark wrote: > On Fri, May 13, 2016 at 8:23 PM, Connor Abbott wrote: >> On Fri, May 13, 2016 at 4:14 PM, Rob Clark wrote: >>> On Fri, May 13, 2016 at 4:10 PM, Jason Ekstrand >>> wrote: On Fri, May 13, 2016 at 1:02 PM, Rob Clark wrote: > > From

Re: [Mesa-dev] [RFC] nir/validate: on failure, dump shader w/ offending line annotated

2016-05-13 Thread Rob Clark
On Fri, May 13, 2016 at 8:23 PM, Connor Abbott wrote: > On Fri, May 13, 2016 at 4:14 PM, Rob Clark wrote: >> On Fri, May 13, 2016 at 4:10 PM, Jason Ekstrand wrote: >>> On Fri, May 13, 2016 at 1:02 PM, Rob Clark wrote: From: Rob Clark If we assert in nir_validate_shader(), p

Re: [Mesa-dev] [RFC] nir/validate: on failure, dump shader w/ offending line annotated

2016-05-13 Thread Connor Abbott
On Fri, May 13, 2016 at 4:14 PM, Rob Clark wrote: > On Fri, May 13, 2016 at 4:10 PM, Jason Ekstrand wrote: >> On Fri, May 13, 2016 at 1:02 PM, Rob Clark wrote: >>> >>> From: Rob Clark >>> >>> If we assert in nir_validate_shader(), print the shader with the >>> offending instruction prefixed wit

Re: [Mesa-dev] [RFC] nir/validate: on failure, dump shader w/ offending line annotated

2016-05-13 Thread Eric Anholt
Rob Clark writes: > From: Rob Clark > > If we assert in nir_validate_shader(), print the shader with the > offending instruction prefixed with "=>" to make it easier to find what > part of the shader nir_validate is complaining about. > > Macro funny-business in nir_validate() was just to avoid

Re: [Mesa-dev] [RFC] nir/validate: on failure, dump shader w/ offending line annotated

2016-05-13 Thread Rob Clark
On Fri, May 13, 2016 at 4:14 PM, Rob Clark wrote: > On Fri, May 13, 2016 at 4:10 PM, Jason Ekstrand wrote: >> On Fri, May 13, 2016 at 1:02 PM, Rob Clark wrote: >>> >>> From: Rob Clark >>> >>> If we assert in nir_validate_shader(), print the shader with the >>> offending instruction prefixed wit

Re: [Mesa-dev] [RFC] nir/validate: on failure, dump shader w/ offending line annotated

2016-05-13 Thread Rob Clark
On Fri, May 13, 2016 at 4:10 PM, Jason Ekstrand wrote: > On Fri, May 13, 2016 at 1:02 PM, Rob Clark wrote: >> >> From: Rob Clark >> >> If we assert in nir_validate_shader(), print the shader with the >> offending instruction prefixed with "=>" to make it easier to find what >> part of the shader

Re: [Mesa-dev] [RFC] nir/validate: on failure, dump shader w/ offending line annotated

2016-05-13 Thread Jason Ekstrand
On Fri, May 13, 2016 at 1:02 PM, Rob Clark wrote: > From: Rob Clark > > If we assert in nir_validate_shader(), print the shader with the > offending instruction prefixed with "=>" to make it easier to find what > part of the shader nir_validate is complaining about. > > Macro funny-business in n

[Mesa-dev] [RFC] nir/validate: on failure, dump shader w/ offending line annotated

2016-05-13 Thread Rob Clark
From: Rob Clark If we assert in nir_validate_shader(), print the shader with the offending instruction prefixed with "=>" to make it easier to find what part of the shader nir_validate is complaining about. Macro funny-business in nir_validate() was just to avoid changing a bazillion assert() li