Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-15 Thread Rob Clark
On Wed, Apr 15, 2015 at 10:32 AM, Connor Abbott wrote: >> >> But more immediately, I hit a sort of snag: I cannot seem to narrow >> from 32b to 16b at the same time I move to address register. Which >> ends up meaning I need a mov from 32b to 16b followed by a 2nd mov to >> get it into address r

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-15 Thread Connor Abbott
On Tue, Apr 14, 2015 at 7:08 PM, Rob Clark wrote: > On Tue, Apr 14, 2015 at 6:24 PM, Connor Abbott wrote: >> On Tue, Apr 14, 2015 at 5:16 PM, Rob Clark wrote: >>> On Tue, Apr 14, 2015 at 4:59 PM, Jason Ekstrand >>> wrote: > + /** > +* Addressing mode for corresponding _in

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Rob Clark
On Tue, Apr 14, 2015 at 7:08 PM, Rob Clark wrote: > On Tue, Apr 14, 2015 at 6:24 PM, Connor Abbott wrote: >> On Tue, Apr 14, 2015 at 5:16 PM, Rob Clark wrote: >>> On Tue, Apr 14, 2015 at 4:59 PM, Jason Ekstrand >>> wrote: > + /** > +* Addressing mode for corresponding _in

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Rob Clark
On Tue, Apr 14, 2015 at 6:24 PM, Connor Abbott wrote: > On Tue, Apr 14, 2015 at 5:16 PM, Rob Clark wrote: >> On Tue, Apr 14, 2015 at 4:59 PM, Jason Ekstrand wrote: + /** +* Addressing mode for corresponding _indirect intrinsics: +*/ + nir_addressin

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Connor Abbott
On Tue, Apr 14, 2015 at 5:16 PM, Rob Clark wrote: > On Tue, Apr 14, 2015 at 4:59 PM, Jason Ekstrand wrote: >>> + /** >>> +* Addressing mode for corresponding _indirect intrinsics: >>> +*/ >>> + nir_addressing_mode var_addressing_mode; >>> + nir_addressing_mode in

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Rob Clark
On Tue, Apr 14, 2015 at 4:59 PM, Jason Ekstrand wrote: >> + /** >> +* Addressing mode for corresponding _indirect intrinsics: >> +*/ >> + nir_addressing_mode var_addressing_mode; >> + nir_addressing_mode input_addressing_mode; >> + nir_addressing_mode output

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Jason Ekstrand
On Tue, Apr 14, 2015 at 12:56 PM, Rob Clark wrote: > On Tue, Apr 14, 2015 at 3:32 PM, Jason Ekstrand wrote: >> On Tue, Apr 14, 2015 at 11:54 AM, Rob Clark wrote: >>> On Tue, Apr 14, 2015 at 1:56 PM, Eric Anholt wrote: Rob Clark writes: > From: Rob Clark > > Add compiler

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Ilia Mirkin
On Tue, Apr 14, 2015 at 3:47 PM, Jason Ekstrand wrote: > On Tue, Apr 14, 2015 at 12:44 PM, Ilia Mirkin wrote: >> On Tue, Apr 14, 2015 at 3:32 PM, Jason Ekstrand wrote: >>> On Tue, Apr 14, 2015 at 11:54 AM, Rob Clark wrote: On Tue, Apr 14, 2015 at 1:56 PM, Eric Anholt wrote: > Rob Clar

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Rob Clark
On Tue, Apr 14, 2015 at 3:32 PM, Jason Ekstrand wrote: > On Tue, Apr 14, 2015 at 11:54 AM, Rob Clark wrote: >> On Tue, Apr 14, 2015 at 1:56 PM, Eric Anholt wrote: >>> Rob Clark writes: >>> From: Rob Clark Add compiler options so driver can request the units for address value, >>

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Jason Ekstrand
On Tue, Apr 14, 2015 at 12:44 PM, Ilia Mirkin wrote: > On Tue, Apr 14, 2015 at 3:32 PM, Jason Ekstrand wrote: >> On Tue, Apr 14, 2015 at 11:54 AM, Rob Clark wrote: >>> On Tue, Apr 14, 2015 at 1:56 PM, Eric Anholt wrote: Rob Clark writes: > From: Rob Clark > > Add compile

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Ilia Mirkin
On Tue, Apr 14, 2015 at 3:32 PM, Jason Ekstrand wrote: > On Tue, Apr 14, 2015 at 11:54 AM, Rob Clark wrote: >> On Tue, Apr 14, 2015 at 1:56 PM, Eric Anholt wrote: >>> Rob Clark writes: >>> From: Rob Clark Add compiler options so driver can request the units for address value, >>

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Kenneth Graunke
On Tuesday, April 14, 2015 12:32:47 PM Jason Ekstrand wrote: > On Tue, Apr 14, 2015 at 11:54 AM, Rob Clark wrote: > > On Tue, Apr 14, 2015 at 1:56 PM, Eric Anholt wrote: [snip] > >> This seems like a good idea, as it'll mean we can have passes that do > >> things like scalarizing uniform loads, w

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Jason Ekstrand
On Tue, Apr 14, 2015 at 11:54 AM, Rob Clark wrote: > On Tue, Apr 14, 2015 at 1:56 PM, Eric Anholt wrote: >> Rob Clark writes: >> >>> From: Rob Clark >>> >>> Add compiler options so driver can request the units for address value, >>> for the various _indirect intrinsics. This way, the front end

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Rob Clark
On Tue, Apr 14, 2015 at 1:56 PM, Eric Anholt wrote: > Rob Clark writes: > >> From: Rob Clark >> >> Add compiler options so driver can request the units for address value, >> for the various _indirect intrinsics. This way, the front end can >> insert the appropriate multiply/shift operations to

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Eric Anholt
Rob Clark writes: > From: Rob Clark > > Add compiler options so driver can request the units for address value, > for the various _indirect intrinsics. This way, the front end can > insert the appropriate multiply/shift operations to get the address into > the units that the driver needs, avoid

[Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Rob Clark
From: Rob Clark Add compiler options so driver can request the units for address value, for the various _indirect intrinsics. This way, the front end can insert the appropriate multiply/shift operations to get the address into the units that the driver needs, avoiding need for driver to insert t