Re: [Mesa-dev] [RFC] radeonsi: guard against indexbuf not being set

2018-03-19 Thread Marek Olšák
Can you test this? diff --git a/src/mesa/state_tracker/st_draw.c b/src/mesa/state_tracker/st_draw.c index b95a2522b2e..73f936bb4a9 100644 --- a/src/mesa/state_tracker/st_draw.c +++ b/src/mesa/state_tracker/st_draw.c @@ -173,6 +173,13 @@ st_draw_vbo(struct gl_context *ctx, /* indices are

Re: [Mesa-dev] [RFC] radeonsi: guard against indexbuf not being set

2018-03-19 Thread Clemens Eisserer
Hi Marek and Roman, > Set this environment variable to disable multithreading: > GALLIUM_THREAD=0 Thanks, so at least I get now a proper stacktrace (at the bottom). I am no OpenGL expert, the only thing I find suspicious is that the last function before entering mesa code actually has a paramete

Re: [Mesa-dev] [RFC] radeonsi: guard against indexbuf not being set

2018-03-19 Thread Marek Olšák
Set this environment variable to disable multithreading: GALLIUM_THREAD=0 Marek On Mon, Mar 19, 2018 at 1:05 PM, Clemens Eisserer wrote: > Hi, > > >> This is a RFC because I don't really know what I'm doing here. But we > >> have this problem with AMD and KWin already for quite a long time and

Re: [Mesa-dev] [RFC] radeonsi: guard against indexbuf not being set

2018-03-19 Thread Clemens Eisserer
Hi, >> This is a RFC because I don't really know what I'm doing here. But we >> have this problem with AMD and KWin already for quite a long time and >> I hope it can be fixed now. > If index_size > 0, indexbuf should always be non-NULL. This is a bug > somewhere else. I've also been bitten by th

Re: [Mesa-dev] [RFC] radeonsi: guard against indexbuf not being set

2018-03-06 Thread Marek Olšák
If index_size > 0, indexbuf should always be non-NULL. This is a bug somewhere else. Marek On Mon, Mar 5, 2018 at 4:42 PM, Roman Gilg wrote: > This is a RFC because I don't really know what I'm doing here. But we > have this problem with AMD and KWin already for quite a long time and > I hope it

Re: [Mesa-dev] [RFC] radeonsi: guard against indexbuf not being set

2018-03-05 Thread Roman Gilg
This is a RFC because I don't really know what I'm doing here. But we have this problem with AMD and KWin already for quite a long time and I hope it can be fixed now. I followed the debug output and tried this guard. On my system this fixed the issue with Alt+Tab crashing KWin. Still this might b

[Mesa-dev] [RFC] radeonsi: guard against indexbuf not being set

2018-03-05 Thread Roman Gilg
Fixes crashes of clients when index_size != 0, but there was no indexbuf set in si_draw_vbo. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103234 Signed-off-by: Roman Gilg --- src/gallium/drivers/radeonsi/si_state_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git