Re: [Mesa-dev] [RFC] vc4: Remove logically dead variable 'handled_qinst_cond'

2016-02-12 Thread Rhys Kidd
Thanks Eric, that makes sense. I'll respin the patch, confirm no piglit regressions and send it back to the mailing list for your R-b. Regards, Rhys On Friday, February 12, 2016, Eric Anholt wrote: > Rhys Kidd > writes: > > > Variable no longer is read, and always set to true. > > > > Accordin

Re: [Mesa-dev] [RFC] vc4: Remove logically dead variable 'handled_qinst_cond'

2016-02-11 Thread Eric Anholt
Rhys Kidd writes: > Variable no longer is read, and always set to true. > > Accordingly, the later assert() serves no active current purpose. The prior > limb of the test 'qinst->cond == QPU_COND_ALWAYS' will never trigger an > assert() > as is. If it did previously define a relevant test, this

[Mesa-dev] [RFC] vc4: Remove logically dead variable 'handled_qinst_cond'

2016-02-11 Thread Rhys Kidd
Variable no longer is read, and always set to true. Accordingly, the later assert() serves no active current purpose. The prior limb of the test 'qinst->cond == QPU_COND_ALWAYS' will never trigger an assert() as is. If it did previously define a relevant test, this should be revisited in a subsequ