Re: [Mesa-dev] [RFC 00/20] shader compiler cache

2014-06-11 Thread Ian Romanick
I've been looking at this is a bit since last week, and I have some concerns about the overall way things are structured. There are also almost no checks that the values being de-serialized are valid. What happens if an ir_expression::operation is 0xDEADBEEF? I think I know where we want to be

Re: [Mesa-dev] [RFC 00/20] shader compiler cache

2014-06-11 Thread Tapani Pälli
Hi; On 06/02/2014 03:05 PM, Tapani Pälli wrote: Hello; This series provides a disk cache for the shader compiler and is used to 'skip glLinkProgram' like GL_ARB_get_program_binary does but under the hood without api for the client. With the series I get 50% improvement for L4D2 startup

Re: [Mesa-dev] [RFC 00/20] shader compiler cache

2014-06-03 Thread Tapani
On 06/02/2014 09:22 PM, Kenneth Graunke wrote: On Monday, June 02, 2014 07:44:15 PM Benjamin Bellec wrote: [snip] The canary error on Google points to a previously closed bug from glsl-compiler : https://bugs.freedesktop.org/show_bug.cgi?id=58039 It's probably unrelated - failing the canary

[Mesa-dev] [RFC 00/20] shader compiler cache

2014-06-02 Thread Tapani Pälli
Hello; This series provides a disk cache for the shader compiler and is used to 'skip glLinkProgram' like GL_ARB_get_program_binary does but under the hood without api for the client. Many of the patches are from my 'GL_ARB_get_program_binary' series and some were reviewed by Paul earlier.

Re: [Mesa-dev] [RFC 00/20] shader compiler cache

2014-06-02 Thread Benjamin Bellec
Hello, This patch set prevents me from launching Steam. I'm on r600g (Radeon HD5850 Evergreen). Here is the log : $ MESA_DEBUG=1 LIBGL_DEBUG=1 STEAM_RUNTIME=0 steam Running Steam on fedora 19 64-bit STEAM_RUNTIME is disabled by the user Installing breakpad exception handler for

Re: [Mesa-dev] [RFC 00/20] shader compiler cache

2014-06-02 Thread Kenneth Graunke
On Monday, June 02, 2014 07:44:15 PM Benjamin Bellec wrote: [snip] The canary error on Google points to a previously closed bug from glsl-compiler : https://bugs.freedesktop.org/show_bug.cgi?id=58039 It's probably unrelated - failing the canary check basically just means you botched your

Re: [Mesa-dev] [RFC 00/20] shader compiler cache

2014-06-02 Thread Tapani Pälli
Hi; On 06/02/2014 08:44 PM, Benjamin Bellec wrote: Hello, This patch set prevents me from launching Steam. I'm on r600g (Radeon HD5850 Evergreen). Thanks for testing the patches! What I forgot to state in the mail was that I've only been able to test this with Intel i965 driver, things might