Re: [Mesa-dev] [RFC 2/3] gallium: Move nv50 clear_texture impl down to util_surface

2015-12-04 Thread Marek Olšák
On Fri, Dec 4, 2015 at 1:37 AM, Ilia Mirkin wrote: > On Thu, Dec 3, 2015 at 7:25 PM, Roland Scheidegger wrote: >> Am 03.12.2015 um 23:48 schrieb Ilia Mirkin: >>> On Thu, Dec 3, 2015 at 4:44 AM, Edward O'Callaghan >>> wrote: ARB_clear_texture is reasonably generic enough that it should

Re: [Mesa-dev] [RFC 2/3] gallium: Move nv50 clear_texture impl down to util_surface

2015-12-03 Thread Ilia Mirkin
On Thu, Dec 3, 2015 at 7:25 PM, Roland Scheidegger wrote: > Am 03.12.2015 um 23:48 schrieb Ilia Mirkin: >> On Thu, Dec 3, 2015 at 4:44 AM, Edward O'Callaghan >> wrote: >>> ARB_clear_texture is reasonably generic enough that it should >>> be moved down to become part of the fallback mechanism of >

Re: [Mesa-dev] [RFC 2/3] gallium: Move nv50 clear_texture impl down to util_surface

2015-12-03 Thread Roland Scheidegger
Am 03.12.2015 um 23:48 schrieb Ilia Mirkin: > On Thu, Dec 3, 2015 at 4:44 AM, Edward O'Callaghan > wrote: >> ARB_clear_texture is reasonably generic enough that it should >> be moved down to become part of the fallback mechanism of >> pipe->clear_texture. >> >> Signed-off-by: Edward O'Callaghan >

Re: [Mesa-dev] [RFC 2/3] gallium: Move nv50 clear_texture impl down to util_surface

2015-12-03 Thread Ilia Mirkin
On Thu, Dec 3, 2015 at 4:44 AM, Edward O'Callaghan wrote: > ARB_clear_texture is reasonably generic enough that it should > be moved down to become part of the fallback mechanism of > pipe->clear_texture. > > Signed-off-by: Edward O'Callaghan > --- > src/gallium/auxiliary/util/u_surface.c

Re: [Mesa-dev] [RFC 2/3] gallium: Move nv50 clear_texture impl down to util_surface

2015-12-03 Thread Roland Scheidegger
One problem with this is that clear_render_target and clear_depth_stencil honor render condition, whereas clear_texture does not. nv50 got it wrong, but I care a lot more when that wrongness is moved to util. This could be fixed by making clear_render_target and clear_depth_stencil optionally honor

Re: [Mesa-dev] [RFC 2/3] gallium: Move nv50 clear_texture impl down to util_surface

2015-12-03 Thread Marek Olšák
On Thu, Dec 3, 2015 at 10:44 AM, Edward O'Callaghan wrote: > ARB_clear_texture is reasonably generic enough that it should > be moved down to become part of the fallback mechanism of > pipe->clear_texture. > > Signed-off-by: Edward O'Callaghan > --- > src/gallium/auxiliary/util/u_surface.c

[Mesa-dev] [RFC 2/3] gallium: Move nv50 clear_texture impl down to util_surface

2015-12-03 Thread Edward O'Callaghan
ARB_clear_texture is reasonably generic enough that it should be moved down to become part of the fallback mechanism of pipe->clear_texture. Signed-off-by: Edward O'Callaghan --- src/gallium/auxiliary/util/u_surface.c | 83 + src/gallium/auxiliary/util/u_surface.