Re: [Mesa-dev] [RFC PATCH] gallium/nir: Add shader-based blending helpers

2018-11-12 Thread Eric Anholt
Alyssa Rosenzweig writes: >> I would love to see this up in src/compiler/nir. > > Is there a compelling reason to have it in NIR rather in Gallium, adding > an extra layer of translation overhead / indirection when coming from > Gallium blend state? (Mythical future Vulkan support, I guess?)

Re: [Mesa-dev] [RFC PATCH] gallium/nir: Add shader-based blending helpers

2018-11-12 Thread Alyssa Rosenzweig
> I would love to see this up in src/compiler/nir. Is there a compelling reason to have it in NIR rather in Gallium, adding an extra layer of translation overhead / indirection when coming from Gallium blend state? (Mythical future Vulkan support, I guess?) > Also, we should probably convert vc4

Re: [Mesa-dev] [RFC PATCH] gallium/nir: Add shader-based blending helpers

2018-11-12 Thread Eric Anholt
Alyssa Rosenzweig writes: > Some mobile GPUs lack fixed-function hardware for blending, instead > emulating blending via internal shaders. In particular for us, vc4 lacks > most of the fragment pipeline, implementing blending in the epilogue of > the fragment shader. Newer Malis supported by

[Mesa-dev] [RFC PATCH] gallium/nir: Add shader-based blending helpers

2018-11-11 Thread Alyssa Rosenzweig
Some mobile GPUs lack fixed-function hardware for blending, instead emulating blending via internal shaders. In particular for us, vc4 lacks most of the fragment pipeline, implementing blending in the epilogue of the fragment shader. Newer Malis supported by Panfrost have limitations in their