[Mesa-dev] [RFC PATCH v1 05/30] anv: Fix get_image_format_properties() - depthstencil (v2)

2017-11-07 Thread Chad Versace
Teach it to calculate the features of depthstencil formats. The goal is to incrementally fix get_image_format_properties() to return a correct result. Currently, it returns incorrect VkFormatFeatureFlags which the caller must clean up. v2: New commit message Reviewed-by: Jason Ekstrand (v1) --

Re: [Mesa-dev] [RFC PATCH v1 05/30] anv: Fix get_image_format_properties() - depthstencil (v2)

2017-11-07 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 07/11/17 14:47, Chad Versace wrote: Teach it to calculate the features of depthstencil formats. The goal is to incrementally fix get_image_format_properties() to return a correct result. Currently, it returns incorrect VkFormatFeatureFlags which the caller mu

Re: [Mesa-dev] [RFC PATCH v1 05/30] anv: Fix get_image_format_properties() - depthstencil (v2)

2017-11-07 Thread Jason Ekstrand
I think I'd prefer we not make "Fix" the first word in the title unless it fixes an actual bug. How about "Refactor"? Same for the ASTC patch. On Tue, Nov 7, 2017 at 6:47 AM, Chad Versace wrote: > Teach it to calculate the features of depthstencil formats. > > The goal is to incrementally fix

Re: [Mesa-dev] [RFC PATCH v1 05/30] anv: Fix get_image_format_properties() - depthstencil (v2)

2017-11-09 Thread Chad Versace
On Tue 07 Nov 2017, Jason Ekstrand wrote: > I think I'd prefer we not make "Fix" the first word in the title unless it > fixes an actual bug.  How about "Refactor"?  Same for the ASTC patch. Sure, I'll s/Fix/Refactor/ in those patches. ___ mesa-dev maili