Re: [Mesa-dev] [v4 PATCH 06/10] i965: Use _mesa_geometry_ functions appropriately

2015-06-09 Thread Ian Romanick
With the comment typo noticed by Ilia fixed (which I did not notice), this patch is Reviewed-by: Ian Romanick On 05/27/2015 02:49 AM, Kevin Rogovin wrote: > Change references to gl_framebuffer::Width, Height, MaxNumLayers > and Visual::samples to use the _mesa_geometry_ convenience functions > f

Re: [Mesa-dev] [v4 PATCH 06/10] i965: Use _mesa_geometry_ functions appropriately

2015-05-27 Thread Ilia Mirkin
Just some trivia: On Wed, May 27, 2015 at 5:49 AM, Kevin Rogovin wrote: > Change references to gl_framebuffer::Width, Height, MaxNumLayers > and Visual::samples to use the _mesa_geometry_ convenience functions Both here and in the subject, I presume you meant _mesa_geometric_* ? > for those pla

[Mesa-dev] [v4 PATCH 06/10] i965: Use _mesa_geometry_ functions appropriately

2015-05-27 Thread Kevin Rogovin
Change references to gl_framebuffer::Width, Height, MaxNumLayers and Visual::samples to use the _mesa_geometry_ convenience functions for those places where the geometry of the gl_framebuffer is needed (in contrast to the geometry of the intersection of the attachments of the gl_framebuffer). This