Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-14 Thread Dylan Baker
Quoting Tapani Pälli (2018-12-14 05:03:06) > > > On 12/14/18 12:53 PM, Erik Faye-Lund wrote: > > On Thu, 2018-12-13 at 10:46 -0800, Eric Anholt wrote: > >> Dylan Baker writes: > >> > >>> [ Unknown signature status ] > >>> In the autotools discussion I've come to realize that we also need > >>> t

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-14 Thread Tapani Pälli
On 12/14/18 12:53 PM, Erik Faye-Lund wrote: On Thu, 2018-12-13 at 10:46 -0800, Eric Anholt wrote: Dylan Baker writes: [ Unknown signature status ] In the autotools discussion I've come to realize that we also need to talk about the -DDEBUG guard. It seems that there are two different uses,

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-14 Thread Erik Faye-Lund
On Thu, 2018-12-13 at 10:46 -0800, Eric Anholt wrote: > Dylan Baker writes: > > > [ Unknown signature status ] > > In the autotools discussion I've come to realize that we also need > > to talk about > > the -DDEBUG guard. It seems that there are two different uses, and > > thus two > > different

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-13 Thread Eric Anholt
Dylan Baker writes: > [ Unknown signature status ] > In the autotools discussion I've come to realize that we also need to talk > about > the -DDEBUG guard. It seems that there are two different uses, and thus two > different asks about it: > > - Nine (and RadeonSI?) use -DDEBUG to hide generic

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-13 Thread Jason Ekstrand
On Thu, Dec 13, 2018 at 11:34 AM Dylan Baker wrote: > Quoting Rob Clark (2018-12-12 16:35:24) > > On Wed, Dec 12, 2018 at 7:14 PM Dylan Baker wrote: > > > > > > Quoting Rob Clark (2018-12-12 15:52:47) > > > > On Wed, Dec 12, 2018 at 6:25 PM Dylan Baker > wrote: > > > > > > > > > > In the autoto

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-13 Thread Dylan Baker
Quoting Rob Clark (2018-12-12 16:35:24) > On Wed, Dec 12, 2018 at 7:14 PM Dylan Baker wrote: > > > > Quoting Rob Clark (2018-12-12 15:52:47) > > > On Wed, Dec 12, 2018 at 6:25 PM Dylan Baker wrote: > > > > > > > > In the autotools discussion I've come to realize that we also need to > > > > talk

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-13 Thread Axel Davy
On 13/12/2018 17:26, Jason Ekstrand wrote: On Thu, Dec 13, 2018 at 5:06 AM Eric Engestrom mailto:eric.engest...@intel.com>> wrote: On Wednesday, 2018-12-12 15:24:25 -0800, Dylan Baker wrote: > In the autotools discussion I've come to realize that we also need to talk about > the

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-13 Thread Jason Ekstrand
On Thu, Dec 13, 2018 at 5:06 AM Eric Engestrom wrote: > On Wednesday, 2018-12-12 15:24:25 -0800, Dylan Baker wrote: > > In the autotools discussion I've come to realize that we also need to > talk about > > the -DDEBUG guard. It seems that there are two different uses, and thus > two > > differen

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-13 Thread Eero Tamminen
Hi, On 13.12.2018 12.19, Eric Engestrom wrote: On Wednesday, 2018-12-12 19:45:06 -0500, Marek Olšák wrote: On Wed, Dec 12, 2018 at 7:35 PM Rob Clark wrote: On Wed, Dec 12, 2018 at 7:14 PM Dylan Baker wrote: Quoting Rob Clark (2018-12-12 15:52:47) ... I guess I should have covered that: a

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-13 Thread Eric Engestrom
On Wednesday, 2018-12-12 15:24:25 -0800, Dylan Baker wrote: > In the autotools discussion I've come to realize that we also need to talk > about > the -DDEBUG guard. It seems that there are two different uses, and thus two > different asks about it: > > - Nine (and RadeonSI?) use -DDEBUG to hide

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-13 Thread Eric Engestrom
On Wednesday, 2018-12-12 19:45:06 -0500, Marek Olšák wrote: > On Wed, Dec 12, 2018 at 7:35 PM Rob Clark wrote: > > > On Wed, Dec 12, 2018 at 7:14 PM Dylan Baker wrote: > > > > > > Quoting Rob Clark (2018-12-12 15:52:47) > > > > On Wed, Dec 12, 2018 at 6:25 PM Dylan Baker > > wrote: > > > > > >

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-12 Thread Ian Romanick
On 12/12/18 4:13 PM, Dylan Baker wrote: > Quoting Rob Clark (2018-12-12 15:52:47) >> On Wed, Dec 12, 2018 at 6:25 PM Dylan Baker wrote: >>> >>> In the autotools discussion I've come to realize that we also need to talk >>> about >>> the -DDEBUG guard. It seems that there are two different uses, a

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-12 Thread Jason Ekstrand
On Wed, Dec 12, 2018 at 6:45 PM Marek Olšák wrote: > On Wed, Dec 12, 2018 at 7:35 PM Rob Clark wrote: > >> On Wed, Dec 12, 2018 at 7:14 PM Dylan Baker wrote: >> > >> > Quoting Rob Clark (2018-12-12 15:52:47) >> > > On Wed, Dec 12, 2018 at 6:25 PM Dylan Baker >> wrote: >> > > > >> > > > In the

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-12 Thread Marek Olšák
On Wed, Dec 12, 2018 at 7:35 PM Rob Clark wrote: > On Wed, Dec 12, 2018 at 7:14 PM Dylan Baker wrote: > > > > Quoting Rob Clark (2018-12-12 15:52:47) > > > On Wed, Dec 12, 2018 at 6:25 PM Dylan Baker > wrote: > > > > > > > > In the autotools discussion I've come to realize that we also need > t

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-12 Thread Rob Clark
On Wed, Dec 12, 2018 at 7:14 PM Dylan Baker wrote: > > Quoting Rob Clark (2018-12-12 15:52:47) > > On Wed, Dec 12, 2018 at 6:25 PM Dylan Baker wrote: > > > > > > In the autotools discussion I've come to realize that we also need to > > > talk about > > > the -DDEBUG guard. It seems that there ar

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-12 Thread Dylan Baker
Quoting Rob Clark (2018-12-12 15:52:47) > On Wed, Dec 12, 2018 at 6:25 PM Dylan Baker wrote: > > > > In the autotools discussion I've come to realize that we also need to talk > > about > > the -DDEBUG guard. It seems that there are two different uses, and thus two > > different asks about it: >

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-12 Thread Rob Clark
On Wed, Dec 12, 2018 at 6:25 PM Dylan Baker wrote: > > In the autotools discussion I've come to realize that we also need to talk > about > the -DDEBUG guard. It seems that there are two different uses, and thus two > different asks about it: > > - Nine (and RadeonSI?) use -DDEBUG to hide generic

[Mesa-dev] Let's talk about -DDEBUG

2018-12-12 Thread Dylan Baker
In the autotools discussion I've come to realize that we also need to talk about the -DDEBUG guard. It seems that there are two different uses, and thus two different asks about it: - Nine (and RadeonSI?) use -DDEBUG to hide generic debugging - NIR and Intel (at least) use -DDEBUG to hide really e