Re: [Mesa-dev] Naming everything in src/gallium/drivers/radeonsi si_*

2014-01-14 Thread Christian König
Am 13.01.2014 22:00, schrieb Andreas Hartmetz: I don't have an fdo account or push rights. Can somebody else push it for me please? I've added the Reviewed-by: lines so the patches only need to be pushed now. You should consider registering an account if you are planning to do more work on

Re: [Mesa-dev] Naming everything in src/gallium/drivers/radeonsi si_*

2014-01-13 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák marek.ol...@amd.com Feel free to push this. Marek On Sat, Jan 11, 2014 at 4:20 PM, Andreas Hartmetz ahartm...@gmail.com wrote: Continuing here because the threads had diverged... I've updated the patch series under the same URL and applied all the

Re: [Mesa-dev] Naming everything in src/gallium/drivers/radeonsi si_*

2014-01-13 Thread Andreas Hartmetz
I don't have an fdo account or push rights. Can somebody else push it for me please? I've added the Reviewed-by: lines so the patches only need to be pushed now. On Monday 13 January 2014 11:22:07 Marek Olšák wrote: For the series: Reviewed-by: Marek Olšák marek.ol...@amd.com Feel free to

Re: [Mesa-dev] Naming everything in src/gallium/drivers/radeonsi si_*

2014-01-13 Thread Marek Olšák
Pushed, thanks. Marek On Mon, Jan 13, 2014 at 10:00 PM, Andreas Hartmetz ahartm...@gmail.com wrote: I don't have an fdo account or push rights. Can somebody else push it for me please? I've added the Reviewed-by: lines so the patches only need to be pushed now. On Monday 13 January 2014

Re: [Mesa-dev] Naming everything in src/gallium/drivers/radeonsi si_*

2014-01-11 Thread Andreas Hartmetz
Continuing here because the threads had diverged... I've updated the patch series under the same URL and applied all the suggested improvements. The variable renames are still in, but at the very end so they are trivial to omit. On Tuesday 07 January 2014 17:27:56 Andreas Hartmetz wrote: We

Re: [Mesa-dev] Naming everything in src/gallium/drivers/radeonsi si_*

2014-01-07 Thread Andreas Hartmetz
We have talked on IRC meanwhile: Everywhere was supposed to mean file names and data structures. I have made a patch series (git link because file renames produce huge diffs) that renames *everything* away from r600 (and also radeonsi) to si, where it is actually about SI. In the such modified

Re: [Mesa-dev] Naming everything in src/gallium/drivers/radeonsi si_*

2014-01-07 Thread Christian König
Don't worry to much about history keeping, anybody who really needs that should be capable of digging that up anyway. I would just squash together the changes Apply si_ file naming scheme in src/gallium/drive… and Fix up file renaming: change file names in commen…. Also please change the

Re: [Mesa-dev] Naming everything in src/gallium/drivers/radeonsi si_*

2014-01-07 Thread Marek Olšák
I agree with everything except these two: Rename the commonly occurring rctx/r600 to now more suitable sctx. Rename the commonly occurring rscreen to now more suitable sscreen. It's too much for my eye to handle. Marek On Tue, Jan 7, 2014 at 5:27 PM, Andreas Hartmetz ahartm...@gmail.com wrote:

Re: [Mesa-dev] Naming everything in src/gallium/drivers/radeonsi si_*

2014-01-07 Thread Marek Olšák
On Tue, Jan 7, 2014 at 5:37 PM, Christian König deathsim...@vodafone.de wrote: Don't worry to much about history keeping, anybody who really needs that should be capable of digging that up anyway. I would just squash together the changes Apply si_ file naming scheme in src/gallium/drive… and

Re: [Mesa-dev] Naming everything in src/gallium/drivers/radeonsi si_*

2014-01-07 Thread Andreas Hartmetz
On Tuesday 07 January 2014 17:37:07 Christian König wrote: Don't worry to much about history keeping, anybody who really needs that should be capable of digging that up anyway. I would just squash together the changes Apply si_ file naming scheme in src/gallium/drive… and Fix up file

Re: [Mesa-dev] Naming everything in src/gallium/drivers/radeonsi si_*

2014-01-07 Thread Andreas Hartmetz
Do you think it's too much change in general or that the patches are too large? They were honestly simple find / sed jobs, so I could fairly easily redo them file by file. I'm not sure how to even argue about that, but I think suitable names are very important. rctx goes as mysterious name /

[Mesa-dev] Naming everything in src/gallium/drivers/radeonsi si_*

2014-01-06 Thread Andreas Hartmetz
Hello, many of the files in radeonsi originally came from other places where they had different names and were never renamed. Most of them now have names that don't tell what the files are for (r600 is not actually the first hardware supported by them, they start at radeonsi), and even those with

Re: [Mesa-dev] Naming everything in src/gallium/drivers/radeonsi si_*

2014-01-06 Thread Marek Olšák
It sounds good, but I'd like the prefix to be si_ everywhere. Marek On Mon, Jan 6, 2014 at 2:47 PM, Andreas Hartmetz ahartm...@gmail.com wrote: Hello, many of the files in radeonsi originally came from other places where they had different names and were never renamed. Most of them now have